Fix GitLab upgrades crashing when LetsEncrypt cert needs renewal (!3402) · Merge requests · GitLab.org / omnibus-gitlab

Stan Hu requested to merge sh-start-nginx-letsencrypt into master Jul 04, 2019

During an upgrade, upgrade.rb runs and shuts down all services not essential to database migrations, including NGINX. reconfigure(false) is then run. If an existing installation already has its LetsEncrypt certificates on disk, NGINX is never started, and the LetsEncrypt HTTP authorization check fails. This causes the GitLab upgrade to fail.

To fix this issue, we only attempt the LetsEncrypt HTTP authorization if NGINX is running.

Closes #4471 (closed)

Edited Nov 17, 2021 by GitLab Release Tools Bot

Fix GitLab upgrades crashing when LetsEncrypt cert needs renewal

Merge request reports