Skip to content
GitLab Next
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • omnibus-gitlab omnibus-gitlab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 992
    • Issues 992
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 57
    • Merge requests 57
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • omnibus-gitlabomnibus-gitlab
  • Merge requests
  • !3369

Fix upgrade version check in preinst to handle 11.11

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Balasankar 'Balu' C requested to merge fix-preinst-version-check into master Jun 24, 2019
  • Overview 12
  • Commits 2
  • Pipelines 4
  • Changes 2

We were using mathematical comparison to match versions because when this was initially implemented, we didn't go to double-digit minor versions. However, mathematical comparison will fail when comparing versions like 11.9 v/s 11.11. So, we have to switch to something that understands version strings. Using sort seems to be the quickest solution.

Edited Jul 01, 2019 by Balasankar 'Balu' C
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: fix-preinst-version-check