Skip to content
GitLab
Next
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • omnibus-gitlab omnibus-gitlab
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 1,059
    • Issues 1,059
    • List
    • Boards
    • Service Desk
    • Milestones
    • Iterations
    • Requirements
  • Merge requests 53
    • Merge requests 53
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • Code review
    • Insights
    • Issue
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.orgGitLab.org
  • omnibus-gitlabomnibus-gitlab
  • Merge requests
  • !2456

Exclude source assets from final package

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Richard Clamp requested to merge rc-3238-exclude-rails-source-assets into master Apr 16, 2018
  • Overview 5
  • Commits 1
  • Pipelines 4
  • Changes 2

What does this MR do?

app/assets, ee/app/assets, and vendor/assets are source directories used by the rails asset pipeline, the compiled outputs in public/assets are all that we need to ship to an end-user

Should save ~23Mb based on gitlab-ee@7732acd

$ du -shc app/assets ee/app/assets vendor/assets
 17M    app/assets
2.5M    ee/app/assets
3.3M    vendor/assets
 23M    total

http://guides.rubyonrails.org/asset_pipeline.html https://gitlab.com/gitlab-org/gitlab-ee/blob/7732acd111e63dfb46075e684ae33e025b2f6f0c/config/application.rb#L116

Checklist

See Definition of done.

  • Change added to CHANGELOG.md. Not applicable for Documentation changes and minor changes.
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA, if applicable
  • MR targeting master branch
  • MR has a green pipeline on GitLab.com

Reviewer Checklist

In addition to above, reviewer must:

  • Pipeline is green on dev.gitlab.org if the change is not touching documentation or internal cookbooks

References

Closes #3238 (closed)

Edited Apr 17, 2018 by Richard Clamp
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: rc-3238-exclude-rails-source-assets