Loading
Update libxslt from 1.1.43 to 1.1.45
What does this MR do?
Updates the bundled libxslt from 1.1.43 to 1.1.45, which includes upstream security fixes. The 19.4.1 package currently ships libxslt 1.1.43.
Changes in config/software/libxslt.rb:
default_versionbumped from1.1.43to1.1.45.version('1.1.45')checksum set to9acfe68419c4d06a45c550321b3212762d92f41465062ca4ea19e632ee5d216e. I computed it from the upstream tarball and confirmed it against GNOME's publishedlibxslt-1.1.45.sha256sum.- The UBT block is unchanged. It only applies when
UBT_TEST_BUILD=true, and no1.1.45-3ubtpackage exists yet.
Local verification
These checks ran in the pinned builder image ubuntu_24.04_arm64:5.74.0, on arm64 only:
- The software definition loads through Omnibus and resolves to
1.1.45with the new checksum and URL. - libxslt 1.1.45 builds against our pinned libxml2 2.15.4 using the recipe's configure flags (
--with-libxml-prefix,--without-python,--without-crypto). Configure found libxml2 2.15.4, which meets the new minimum of 2.15.1. There were 0 compiler warnings. make checkpasses.xsltproc --versionreportslibxslt 10145,libexslt 825, compiled against libxml21504.xsltproclinks to the embeddedlibxslt,libexsltandlibxml2.so.16.- A smoke transform using
xsl:sortand EXSLTstr:paddinggives the expected output. ruby -candrubocoppass on the changed file.
The full multi-OS package build and the libxslt test plan are still pending. See the checklist.
Related issues
Closes https://gitlab.com/gitlab-org/omnibus-gitlab/-/work_items/10202
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is marked as ready (not a draft) and a reviewer is requested. Pick the reviewer suggested by the reviewer roulette, or one of the project maintainers.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
- The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit.- To debug QA failures, refer to the Investigate QA failures section.
- If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. - If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. - If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
- Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Reviewer checklist
- As soon as you begin reviewing, select Start a review on your first comment so the MR shows Reviewer started review.