Update libtiff to 4.7.2
What does this MR do?
Bumps libtiff from 4.7.1 to 4.7.2, as requested in #10120 and tracked in #10204. The 19.4.1 package currently ships libtiff 4.7.1. This MR supersedes the Renovate MR !9580, which only changes the version string and would fail to build on several platforms (see below).
Why the build source changes
libtiff 4.7.2 raised AC_PREREQ from 2.69 to 2.71 (upstream release note: "configure.ac: Require bootstrap with at least Autoconf 2.71"). We built libtiff from the git tag and ran ./autogen.sh, so the build depended on the Autoconf version in each builder image. Several builder images ship Autoconf 2.69, and the bootstrap fails there:
configure.ac:27: error: Autoconf version 2.71 or higher is requiredThis MR switches libtiff to the official release tarball. The tarball ships a configure script that upstream already generated with Autoconf 2.71, so the build no longer depends on the Autoconf version in the image. The same pattern is already used for graphicsmagick.
Changes
config/software/libtiff.rbdefault_version '4.7.2'replaces theGitlab::Versiongit-tag lookup.- Source is
https://download.osgeo.org/libtiff/tiff-4.7.2.tar.gzwith a pinned sha256 (672bd7d10aee4606171afb864f3570b83340f6a33e2c186dc0512f7145ffdf6a) andrelative_path "tiff-#{version}". - The
./autogen.shstep and bothpatchsteps are removed.update_config_guess(target: 'config'),./configure --disable-zstdandmake installare unchanged.
- Removed
config/patches/libtiff/remove-config-guess-sub-download.patchandconfig/patches/libtiff/add-libtoolize-call-to-autogen.patch. Both only modifiedautogen.sh, which no longer runs. The tarball already containsconfig/config.guess,config/config.subandconfig/ltmain.sh, and our vendoredconfig.guess/config.subare still copied in byupdate_config_guess. - Added
scripts/renovate/checksums/software/libtiff.sh, modelled ongraphicsmagick.sh, so Renovate updates the sha256 on future bumps.update_all.shand thevalidate_renovate_checksumjob pick it up automatically.
The SONAME is unchanged: libtool version info goes from 8:0:2 to 9:0:3, so it is still libtiff.so.6 (libtiff.so.6.3.0), with new interfaces added.
Local testing
Run in builder images 5.74.0 (arm64), with no network inside the build containers:
| Image | Autoconf | Git tag + autogen.sh (previous approach) |
Release tarball (this MR) |
|---|---|---|---|
| AlmaLinux 8 | 2.69 | ||
| AlmaLinux 9 | 2.69 | ||
| Debian 11 | 2.69 | ||
| openSUSE 15.6 | 2.69 | ||
| Ubuntu 24.04 | 2.71 | not conclusive (test setup lacked libtool) |
For each tarball build: the sha256 matches the value in libtiff.rb, configure and make install succeed, strings libtiff.so | grep "LIBTIFF, Version" reports 4.7.2, and libtiff.so.6 -> libtiff.so.6.3.0. Upstream make check passes on Ubuntu 24.04.
Also checked:
- Every source file the tarball shares with the
v4.7.2git tag is identical. The tarball only adds generated build files. - The Renovate script, run in the CI
bash:5.2-alpine3.20image, restores a deliberately broken checksum to the correct value. Omnibus::Software.loadoflibtiff.rbin a Linux container resolvesversion=4.7.2, the tarball URL, the sha256 andrelative_path=tiff-4.7.2.bundle exec rubocopreports no offenses, andbundle exec rspec spec/libpasses (637 examples, 0 failures).
Not covered locally: x86_64 builds, FIPS images, and building against the omnibus-provided zlib-ng, liblzma and libjpeg-turbo (the local builds used the images' system libraries). These need Trigger:ee-package / build-package-on-all-os.
Points for review
- UBT checksum not updated. gitlab-toolchain has no libtiff 4.7.2 artifact yet (only
4.7.0,4.7.1and4.7.1-1ubt). WithUBT_TEST_BUILD=trueon x86_64, the definition resolves to…/packages/generic/libtiff/4.7.2/libtiff-4.7.2-x86_64.tgzwith the 4.7.1 sha256. This needs updating once the artifact is built, and the artifact naming needs confirming (4.7.2or4.7.2-1ubt, as for libpng). Non-UBT builds are not affected. - Upstream source instead of the git mirror. libtiff is now fetched from
download.osgeo.orginstead of the git mirror in.custom_sources.yml, as graphicsmagick already does. The mirror entry is left in place. - Tarball signature. The tarball has a GPG signature (
tiff-4.7.2.tar.gz.sig, keyB1FA7D81EEB8E66399178B9733EBBFC47B3DD87D) that was not verified locally because the key isn't in a local keyring. - Renovate datasource. Renovate currently tracks libtiff as a git tag. Its datasource config lives outside this repository and may need updating for the tarball source.
Related issues
Closes #10204
Related: #10120, !9580
Checklist
See Definition of done.
For anything in this list which will not be completed, please provide a reason in the MR discussion.
Required
- MR title and description are up to date, accurate, and descriptive.
- MR targeting the appropriate branch.
- Latest Merge Result pipeline is green.
- When ready for review, MR is marked as ready (not a draft) and a reviewer is requested. Pick the reviewer suggested by the reviewer roulette, or one of the project maintainers.
For GitLab team members
If you don't have access to this, the reviewer should trigger these jobs for you during the review process.
- The manual
Trigger:ee-packagejobs have a green pipeline running against latest commit.- To debug QA failures, refer to the Investigate QA failures section.
- If
config/softwareorconfig/patchesdirectories are changed, make sure thebuild-package-on-all-osjob within theTrigger:ee-packagedownstream pipeline succeeded. - If you are changing anything SSL related, then the
Trigger:package:fipsmanual job within theTrigger:ee-packagedownstream pipeline must succeed. - If CI configuration is changed, the branch must be pushed to
dev.gitlab.orgto confirm regular branch builds aren't broken.
Expected (please provide an explanation if not completing)
- Test plan indicating conditions for success has been posted and passes.
- Documentation created/updated.
- Tests added.
- Integration tests added to GitLab QA.
- Equivalent MR/issue for the GitLab Chart opened.
- Validate potential values for new configuration settings. Formats such as integer
10, duration10s, URIscheme://user:passwd@host:portmay require quotation or other special handling when rendered in a template and written to a configuration file.
Reviewer checklist
- As soon as you begin reviewing, select Start a review on your first comment so the MR shows Reviewer started review.