Skip to content

fix: dont return error on already completed sessions

Halil Cobanrequested to merge
retrying-successful-sessions into main

What does this merge request do and why?

When a session that was already completed, is retried, an error is raised.

Can not retry workflow that has status finished

and gRPC code is set to INTERNAL.

With this MR, we return success, instead.

How to set up and validate locally

This is difficult to validate using the editor extension, I have followed the following steps to validate locally

  1. Using go executor, run a workflow and let it finish
  2. Run the same workflow again, it should not raise errors.

Merge request checklist

  • Tests added for new functionality. If not, please raise an issue to follow up.
  • Documentation added/updated, if needed.
  • If this change requires executor implementation: verified that issues/MRs exist for both Go executor and Node executor or confirmed that changes are backward-compatible and don't break existing executor functionality.

Merge request reports