Skip to content

feat(duoworkflow): use new http response in status updater

What does this merge request do and why?

This MR adds functionality to use the new httpResponse action response that is being added to executor.

There are several places that tries to parse the action response without any checks, thus this change will be introduced gradually. This MR adds it to workflow status updater. It's intented to address alerts such as this.

As part of: #951 (closed)

Note: This MR is still marked as Draft as Duo Workflow Executor dependency in Rails is not released, yet.

How to set up and validate locally

  1. Check out to this merge request's branch.
  2. Check out executor to this branch.
  3. Make a change that should cause an error response from gitlab api for workflow status update. For example you can change the path to a non-existing path in update_workflow_status to trigger 404.
  4. Run a workflow
  5. You should not see json decode error
  6. You should see an exception log like Failed to update workflow ...

Merge request checklist

  • Tests added for new functionality. If not, please raise an issue to follow up.
  • Documentation added/updated, if needed.
Edited by Halil Coban

Merge request reports

Loading