Skip to content

Adding Preflight Checks to Make Install

Stephan Rayner requested to merge make-install-preflight-checks into main

What does this merge request do and why?

This merge request adds a step before make install which ensures that the developer has poetry and node which are two of the main developer dependencies of this project.

How to set up and validate locally

  1. Clone this repo
  2. Check out this branch
  3. Run make preflight
  4. Run make install and notice that preflight also ran
  5. For an extra saucy time, uninstall node and run make install and notice that the preflight step fails causing the install step to stop before it even starts. ⚠ sure you reinstall node after you run this test.

Merge request checklist

  • Tests added for new functionality. If not, please raise an issue to follow up.
  • Documentation added/updated, if needed.
Edited by Stephan Rayner

Merge request reports