fix formatting of latency in combined access log
1 unresolved thread
1 unresolved thread
I noticed while running gdk locally that the latency field in the combined access log has the wrong type:
2020-03-05_09:30:41.77301 gitlab-workhorse : localhost:3000 127.0.0.1 - - [2020/03/05:10:30:41 +0100] "GET /favicon.ico HTTP/1.1" 502 583 "http://localhost:3000/root/example/-/tree/master" "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_3) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.122 Safari/537.36" %!f(int64=001)
See the %!f(int64=001)
at the end.
This patch changes the formatting for latency to be %d
for int64.
Edited by Igor
Merge request reports
Activity
assigned to @zj-gitlab and @steveazz
- Resolved by Igor
Good spot @igorwwwwwwwwwwwwwwwwwwww! Could you show demonstrate how this looks using JSON formatting too please?
added 1 commit
- 19291deb - flip things around and use an int everywhere instead
unassigned @zj-gitlab
added 1 commit
- c57f2fa6 - update backwards_compat_workhorse to go 1.13
@andrewn please take another look!
looks good to me. Thanks @igorwwwwwwwwwwwwwwwwwwww
mentioned in commit b34ac279
mentioned in merge request !47 (merged)
mentioned in issue #37 (closed)
Please register or sign in to reply