Skip to content

Remove docker logins from the CLI

Nick Thomas requested to merge docker-build-instructions into master

Remove login flags from the CLI:

 -u MyGitlabUsername \            # GitLab username to connect to container registry
 -p MyGitlabAccessToken \         # GitLab PAT with permissions to access container registry

Reasons:

  1. Security - They will be stored in the history file
  2. We have access to the TTY and we can ask the user to type them to the STDIN. We can even let docker login registry to do it for us in a similar way to how sudo is used in bash scripts.

@fabiopitino what do you think?

Merge request reports