Remove docker logins from the CLI
Remove login flags from the CLI:
-u MyGitlabUsername \ # GitLab username to connect to container registry
-p MyGitlabAccessToken \ # GitLab PAT with permissions to access container registry
Reasons:
- Security - They will be stored in the history file
- We have access to the TTY and we can ask the user to type them to the STDIN. We can even let
docker login registry
to do it for us in a similar way to howsudo
is used in bash scripts.
@fabiopitino what do you think?