Vue.js create room flow
Vue.js create room flow.
One big change is that you can now create a room and associate it with any repo you have admin access to. Previously repo association in the UI only happened if the URI matched directly with GitHub. This wasn't a backend change so was possible before in the API. I think it feels a lot nicer to be able to associate your repo with any room and makes sense to allow this to gear up for the GitHub URI split.
Part of https://gitlab.com/gitlab-org/gitter/webapp/issues/2411
MR to remove old create room code: https://gitlab.com/gitlab-org/gitter/webapp/-/merge_requests/1831
| . | . | . | . |
|---|---|---|---|
 |
 |
 |
 |
| Errors | . | . |
|---|---|---|
 |
 |
. |
Testing strategy
- Play with the modal in general
- Create a public room
- Create a private room
- Create a room associated with a GitHub repo
- Create a room associated with a GitLab project
The modal state does not reset between closing and opening. Not totally against resetting but thought it was useful so you can go out, get help with your OAuth problems and jump back in. It does re-fetch your admin groups and repos as those may have changed in the time frame.
Todo
-
Select initial community -
Auto-associate repo when typed same name -
Turn off strict Vuex store in production, https://gitlab.com/gitlab-org/gitter/webapp/-/merge_requests/1818#note_323097929 -
Tests -
Update e2e tests