Skip to content

Custom Metrics backend and UI for creating and editing queries

What does this MR do?

Adds support for custom metrics

Screenshots (if relevant)

When there's no custom metrics Screen_Shot_2018-02-08_at_5.36.56_PM

Form for adding metrics

Adding Screen_Shot_2018-03-05_at_1.10.29_PM

Editing Screen_Shot_2018-03-05_at_1.10.41_PM

When there's custom metrics Screen_Shot_2018-03-06_at_11.37.19_AM

When there's custom metrics and no deployments Screen_Shot_2018-03-06_at_11.35.55_AM

No default metrics/custom metrics

With no deployment Screen_Shot_2018-02-08_at_5.37.05_PM

When deployed and no common metrics were found Screen_Shot_2018-02-28_at_12.35.13_PM

The dashboard itself Screen_Shot_2018-03-05_at_1.11.29_PM

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Implement Query Validation using Prometheus
  • Use added queries to query prometheus and return responses in additional queries endpoint
  • Documentation created/updated
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan

What are the relevant issue numbers?

Related to: #2273 (closed)

CE backport of common metric changes:

https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/17586

Edited by Filipa Lacerda

Merge request reports