Skip to content

Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
    • Help
    • Support
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
    • Cycle Analytics
    • Insights
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Charts
    • Locked Files
  • Issues 23,811
    • Issues 23,811
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 855
    • Merge Requests 855
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
    • Charts
  • Security & Compliance
    • Security & Compliance
    • Dependency List
  • Packages
    • Packages
    • Container Registry
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Charts
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • GitLab.org
  • GitLabGitLab
  • Merge Requests
  • !3672

Merged
Opened Dec 07, 2017 by Dmitriy Zaporozhets@dzaporozhets9 of 13 tasks completed9/13 tasks
  • Report abuse
Report abuse

Resolve "Show results from docker image scan in the merge request widget"

  • Overview 49
  • Commits 22
  • Pipelines 19
  • Changes 20

What does this MR do?

Shows result of CI scan on docker image

Frontend

  • Adds support to fetch clair report
  • Parses and stores received data
  • Adds support in collapsible section to render text information
  • Adds support in issue component to render an extra type
  • Adds tests to all changed components & store, for success and error cases.

Are there points in the code the reviewer needs to double check?

no

Why was this MR needed?

To integrate container static analysis into MR widget. First step in https://gitlab.com/gitlab-org/gitlab-ee/issues/3724

Screenshots (if relevant)

|loading|error|no vulnerabilities|vulnerabilities| |--|--|--|--|--|--| |Screen_Shot_2017-12-12_at_19.26.16|Screen_Shot_2017-12-12_at_19.26.46|Screen_Shot_2017-12-12_at_19.28.40|Screen_Shot_2017-12-13_at_18.39.30|

Does this MR meet the acceptance criteria?

  • Changelog entry added, if necessary
  • Documentation created/updated https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3781
  • API support added
  • Tests added for this feature/bug
  • Review
    • Has been reviewed by UX
    • Has been reviewed by Frontend
    • Has been reviewed by Backend
    • Has been reviewed by Database
  • Conform by the merge request performance guides
  • Conform by the style guides
  • Squashed related commits together
  • Internationalization required/considered
  • If paid feature, have we considered GitLab.com plan and how it works for groups and is there a design for promoting it to users who aren't on the correct plan

What are the relevant issue numbers?

Closes #4249 (closed)

Edited Dec 14, 2017 by Dmitriy Zaporozhets
Assignee
Assign to
10.4
Milestone
10.4
Assign milestone
Time tracking
9
Labels
CI/CD [DEPRECATED] Deliverable Enterprise Edition GitLab Ultimate Plan [DEPRECATED] Secure [DEPRECATED] UX frontend merge requests
Assign labels
  • View project labels
Reference: gitlab-org/gitlab!3672

Revert this merge request

This will create a new commit in order to revert the existing changes.

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.

Cherry-pick this merge request

Switch branch
Cancel
A new branch will be created in your fork and a new merge request will be started.