Make LetsEncrypt order expiration shorter
What does this MR do?
Problem to solve:
- We currently don't handle Let's Encrypt errors properly: #30146 (closed)
- We just wait untill Acme Order is expired and retry
- The default expiration time for them is 1 week
Most common scenario:
- User adds domain and verifies it quickly(before pages-daemon have a chance to update the config)
- GitLab creates Let's Encrypts order
- Let's Encrypt tries to verify pages domain but hits 404(pages daemon still doesn't know about the domain)
- Order is in the failed state and will be tried only when expired
This MR just limits the lifetime of Acme Order to 2 hours. It's a workaround, but it fixes a very annoying issue.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Vladimir Shushlin