Fix GitLab plugins not working without hooks configured
gitlab-foss!31741 (merged), shipped
in GitLab 12.2, reduced Gitaly RPCs by generating commit data only if
hooks or services were actually active. However, GitLab plugins
(https://docs.gitlab.com/ee/administration/plugins.html), are executable
programs that get launched inside SystemHooksService#execute_hooks
regardless of whether any hooks are actually active. As a result of this
change, users have to configure a Webhook for plugins to fire.
We restore the previous behavior by checking whether plugins are
available and executing SystemHooksService#execute_hooks
if any
plugins are available.
Closes #194131 (closed)
Merge request reports
Activity
changed milestone to %12.7
added groupecosystem [DEPRECATED] regression:12.2 + 1 deleted label
added 1 commit
- 9ef35e16 - Fix GitLab plugins not working without hooks configured
1 Warning ⚠ ef11b418: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Ethan Urie ( @eurie
)Bob Van Landuyt ( @reprazent
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added 1 commit
- a35fcd42 - Fix GitLab plugins not working without hooks configured
added typebug label
assigned to @arturoherrero and unassigned @stanhu
- Resolved by Stan Hu
- Resolved by Stan Hu
assigned to @stanhu and unassigned @arturoherrero
Thanks @stanhu! Just a couple of small things but feel free to pass to the maintainer review after that.
I'm not sure about my suggestion to improve the spec performance vs spec single responsibility, it's up to you.
added 10 commits
-
a35fcd42...637c65be - 9 commits from branch
master
- ef11b418 - Fix GitLab plugins not working without hooks configured
-
a35fcd42...637c65be - 9 commits from branch
assigned to @dzaporozhets and unassigned @stanhu
added regression label
Setting devopsenablement based on ~"group::ecosystem".
added devopssystems label
@stanhu thanks, LGTM!
mentioned in commit 403b60b1
Automatically picked into !22674 (merged), will merge into
12-6-stable-ee
ready for12.6.3-ee
.mentioned in commit 96007722
mentioned in merge request !22674 (merged)
mentioned in commit 7816adee
added 1 deleted label and removed devopssystems label
added devopsmanage label and removed 1 deleted label