Skip to content
Snippets Groups Projects

Fix GitLab plugins not working without hooks configured

Merged Stan Hu requested to merge sh-fix-plugins-not-executing into master
All threads resolved!

gitlab-foss!31741 (merged), shipped in GitLab 12.2, reduced Gitaly RPCs by generating commit data only if hooks or services were actually active. However, GitLab plugins (https://docs.gitlab.com/ee/administration/plugins.html), are executable programs that get launched inside SystemHooksService#execute_hooks regardless of whether any hooks are actually active. As a result of this change, users have to configure a Webhook for plugins to fire.

We restore the previous behavior by checking whether plugins are available and executing SystemHooksService#execute_hooks if any plugins are available.

Closes #194131 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports

Merge request pipeline #106853577 passed with warnings

Merge request pipeline passed with warnings for ef11b418

Test coverage 87.09% (0.00%) from 2 jobs

Merged by Dmytro Zaporozhets (DZ)Dmytro Zaporozhets (DZ) 5 years ago (Jan 6, 2020 7:28am UTC)

Loading

Pipeline #107200916 passed with warnings

Pipeline passed with warnings for 403b60b1 on master

Test coverage 87.09% (0.00%) from 2 jobs
4 environments impacted.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Arturo Herrero
  • Arturo Herrero assigned to @stanhu and unassigned @arturoherrero

    assigned to @stanhu and unassigned @arturoherrero

  • Arturo Herrero approved this merge request

    approved this merge request

  • Thanks @stanhu! Just a couple of small things but feel free to pass to the maintainer review after that.

    I'm not sure about my suggestion to improve the spec performance vs spec single responsibility, it's up to you.

  • Stan Hu resolved all threads

    resolved all threads

  • Stan Hu added 10 commits

    added 10 commits

    Compare with previous version

  • Stan Hu assigned to @dzaporozhets and unassigned @stanhu

    assigned to @dzaporozhets and unassigned @stanhu

  • Setting devopsenablement based on ~"group::ecosystem".

  • Dmytro Zaporozhets (DZ) approved this merge request

    approved this merge request

  • mentioned in commit 403b60b1

  • Automatically picked into !22674 (merged), will merge into 12-6-stable-ee ready for 12.6.3-ee.

  • GitLab Release Tools Bot removed 1 deleted label

    removed 1 deleted label

  • mentioned in commit 96007722

  • mentioned in merge request !22674 (merged)

  • mentioned in commit 7816adee

  • Yorick Peterse removed 1 deleted label

    removed 1 deleted label

  • Yorick Peterse removed 1 deleted label

    removed 1 deleted label

  • 🤖 GitLab Bot 🤖 changed the description

    changed the description

  • 🤖 GitLab Bot 🤖 added 1 deleted label and removed devopssystems label

    added 1 deleted label and removed devopssystems label

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading