Skip to content
Snippets Groups Projects

Handle forbidden error when checking for knative

Merged Alex Ives requested to merge alexives/119379/handle_http_error_instead_of_not_found into master

What does this MR do?

This change handles a 403 when the knative-serving namespace doesn't exist.

Fixes #119379 (closed) Relates to #55246 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Alex Ives added 1 commit

    added 1 commit

    • aab1bd05 - Handle forbidden error when checking for knative

    Compare with previous version

  • Alex Ives changed the description

    changed the description

  • Author Maintainer

    @tkuah when you have a chance to re-review this I'd super appreciate it!

  • Alex Ives assigned to @tkuah and unassigned @alexives

    assigned to @tkuah and unassigned @alexives

  • Author Maintainer

    @nagyv.gitlab there's been some discussion about if this is actually ~P1 or not, I'd be curious to have you chime in.

  • Thong Kuah
  • Thong Kuah assigned to @alexives and unassigned @tkuah

    assigned to @alexives and unassigned @tkuah

  • Thanks for picking this up @alexives - just one question !

  • mentioned in issue #55246 (closed)

  • Alex Ives added 1 commit

    added 1 commit

    • 0bb6626c - Handle forbidden error when checking for knative

    Compare with previous version

  • Author Maintainer

    @tkuah hope this resolves your remaining questions.

  • Alex Ives assigned to @tkuah and unassigned @alexives

    assigned to @tkuah and unassigned @alexives

  • Thong Kuah marked the checklist item Code review guidelines as completed

    marked the checklist item Code review guidelines as completed

  • Thong Kuah marked the checklist item Style guides as completed

    marked the checklist item Style guides as completed

  • Thong Kuah approved this merge request

    approved this merge request

  • Thong Kuah
  • Thong Kuah added 1 commit

    added 1 commit

    Compare with previous version

  • Thong Kuah resolved all threads

    resolved all threads

  • Thong Kuah enabled an automatic merge when the pipeline for 1d8becf8 succeeds

    enabled an automatic merge when the pipeline for 1d8becf8 succeeds

  • merged

  • Thong Kuah mentioned in commit 6024c4be

    mentioned in commit 6024c4be

  • Automatically picked into 12-7-auto-deploy-20191222, will merge into 12-7-auto-deploy-20191222 ready for 12.7.0-ee.

  • Thong Kuah mentioned in commit 1e05e546

    mentioned in commit 1e05e546

  • This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.7.201912240705-8d31d08783d.56bf792a0d7.

    A list of all the deployed commits can be found here.


    🤖 If this message is incorrect, please create an issue in the Release Tools project.

  • This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.7.201912240705-8d31d08783d.56bf792a0d7.

    A list of all the deployed commits can be found here.


    🤖 If this message is incorrect, please create an issue in the Release Tools project.

  • added workflowcanary label and removed workflowstaging label

  • This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.7.201912241205-7ed33754ed4.8c365c32404.

    A list of all the deployed commits can be found here.


    🤖 If this message is incorrect, please create an issue in the Release Tools project.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading