Handle forbidden error when checking for knative
What does this MR do?
This change handles a 403 when the knative-serving namespace doesn't exist.
Fixes #119379 (closed) Relates to #55246 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added 1 commit
- c294e5db - Handle forbidden error when checking for knative
Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend Charlie Ablett ( @cablett
)Robert Speicher ( @rspeicher
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖added devopsconfigure [DEPRECATED] priority1 + 1 deleted label
marked the checklist item Changelog entry as completed
assigned to @alexives
changed milestone to %12.7
added backstage [DEPRECATED] label
added typebug label
added backend label
added 1 commit
- 44342823 - Handle forbidden error when checking for knative
@mattkasa would you mind doing a first pass review of this?
assigned to @mattkasa
unassigned @mattkasa
added Pick into auto-deploy + 1 deleted label
- Resolved by Thong Kuah
removed backstage [DEPRECATED] label
added 1 commit
- aab1bd05 - Handle forbidden error when checking for knative
@tkuah when you have a chance to re-review this I'd super appreciate it!
- Resolved by Alex Ives
Thanks for picking this up @alexives - just one question !
mentioned in issue #55246 (closed)
added 1 commit
- 0bb6626c - Handle forbidden error when checking for knative
@tkuah hope this resolves your remaining questions.
marked the checklist item Code review guidelines as completed
marked the checklist item Style guides as completed
- Resolved by Thong Kuah
enabled an automatic merge when the pipeline for 1d8becf8 succeeds
mentioned in commit 6024c4be
removed Pick into auto-deploy label
mentioned in commit 1e05e546
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.7.201912240705-8d31d08783d.56bf792a0d7
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.7.201912240705-8d31d08783d.56bf792a0d7
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.7.201912241205-7ed33754ed4.8c365c32404
.A list of all the deployed commits can be found here.
🤖 If this message is incorrect, please create an issue in the Release Tools project.