Don't use cached node objects for geo:set_secondary_as_primary task
What does this MR do?
If AR objects a recovered from cache they can not be updated anymore as the state is not fully recovered.
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
changed milestone to %12.7
added groupgeo label
added typebug label
1 Warning ⚠ 78579abb: This commit’s subject line is acceptable, but please try to reduce it to 50 characters. Reviewer roulette
Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.
To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.
Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.
Category Reviewer Maintainer backend David Wilkins ( @dwilkins
)Douglas Barbosa Alexandre ( @dbalexandre
)Generated by
🚫 DangerEdited by 🤖 GitLab Bot 🤖mentioned in issue #35735 (closed)
added 1 commit
- 78579abb - Don't use cached nodes for geo:set_secondary_as_primary task
assigned to @toon
added backstage [DEPRECATED] label
@vsizov LGTM.
@dbalexandre Danger says you're the chosen one for mainter review.
assigned to @dbalexandre and unassigned @toon
Thanks, @vsizov! LGTM
👍 mentioned in commit 87e9e00f
- Resolved by Fabian Zimmer
The error makes for an unfortunate experience at a stressful time.
The workaround is not too bad though, if you know about it: Wait 2 minutes before running
gitlab-rake geo:set_secondary_as_primary
. I will open an issue to add the error and workaround to the docs. => #195393 (closed)Also I'm adding the pick into labels.
cc @fzimmer
Edited by Michael Kozono
mentioned in issue #195393 (closed)
Automatically picked into !22674 (merged), will merge into
12-6-stable-ee
ready for12.6.3-ee
.mentioned in commit 566108aa
mentioned in merge request !22674 (merged)
mentioned in commit 7816adee
mentioned in merge request !23403 (merged)
@yorickpeterse quick question: Did you remove the ~"Pick into 12.5" label because no more 12.5 release is anticipated?
@fzimmer Yes, we only do patch releases for the previous release, which is 12.6.
mentioned in issue #220053 (closed)