Skip to content
Snippets Groups Projects

Remove stickyMonitor from diff_file_head.vue

Merged Justin Boyson requested to merge jdb-remove-sticky-monitor-diff-file-header into master
All threads resolved!

What does this MR do?

Related to: #35814 (closed)

Remove stickyMonitor from diff_file_head.vue

In this scenario, stickyMonitor only adds the class is-stuck to diff_file_header. On large diffs, this almost doubles the render time.

All the is-stuck class does is set border-radius to 0. I believe the performance impact is not worth the trade-off.

Screenshots

The visual difference in changes tabs.

image

Load difference ~40% reduction in time

image

Testing

If testing with local seeded projects use this one: http://localhost:3000/Commit451/lab-coat/merge_requests/2/diffs

That is the one I used for my testing.

Here are the stats for that project at the time of writing this MR

image

Does this MR meet the acceptance criteria?

Conformity

Edited by Justin Boyson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Pedro Moreira da Silva approved this merge request

    approved this merge request

  • Justin Boyson added 233 commits

    added 233 commits

    Compare with previous version

  • Justin Boyson resolved all threads

    resolved all threads

  • Author Contributor

    @pslaughter maintainer review please.

  • Justin Boyson added 1 commit

    added 1 commit

    Compare with previous version

  • Paul Slaughter
  • Paul Slaughter
  • Paul Slaughter resolved all threads

    resolved all threads

  • mentioned in issue #39145 (closed)

  • LGTM! Thanks so much for catching this. I'm excited for the performance boost :rocket:

    lgtm

  • Paul Slaughter approved this merge request

    approved this merge request

  • Paul Slaughter mentioned in commit 74abc282

    mentioned in commit 74abc282

  • Amazing @jboyson :100: - this is so good.

  • mentioned in commit 7816adee

  • mentioned in issue #210024

  • Please register or sign in to reply
    Loading