Implement application appearance API
What does this MR do?
This MR implements a new API endpoint /application/appearance
, which makes the content of /admin/appearance
accessible via API.
While the /application/settings
API endpoint already exposes most of the configuration options, there was no automated way to change the appearance settings.
Addresses #16647 (closed)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
marked the checklist item Changelog entry as completed
added 1 commit
- dee56197 - docs(changelog): add changelog entry for appearance API endpoint
added Community contribution label
added customer label
added api label
@lmcandrew could you assign this to a reviewer?
assigned to @manojmj
- Resolved by Manoj M J
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
@fh1ch Thank you so much for your contribution!
Looks good overall, did an initial review and added some questions/suggestions
unassigned @manojmj
added 2387 commits
-
dee56197...0492b97d - 2385 commits from branch
gitlab-org:master
- 6ece29f6 - feat(api): implement application appearance API
- 257dd0bf - docs(changelog): add changelog entry for appearance API endpoint
-
dee56197...0492b97d - 2385 commits from branch
added 1 commit
- a7d557bc - docs(changelog): add changelog entry for appearance API endpoint
assigned to @eread
added backend label
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
mentioned in merge request gitlab-docs!667 (merged)
added 1 commit
- 06e56562 - Apply suggestion to doc/api/api_resources.md
added 1039 commits
-
06e56562...9ba82eae - 1036 commits from branch
gitlab-org:master
- a82eb1fc - feat(api): implement application appearance API
- 32b4f22e - docs(changelog): add changelog entry for appearance API endpoint
- c8007e09 - refactor(doc): improve documentation based on MR feedback
Toggle commit list-
06e56562...9ba82eae - 1036 commits from branch
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
- Resolved by Fabio Huser
assigned to @ashmckenzie
added 106 commits
-
c91533bb...94974e2c - 103 commits from branch
gitlab-org:master
- 3ea073f1 - feat(api): implement application appearance API
- 35cc26e5 - docs(changelog): add changelog entry for appearance API endpoint
- c787cb8e - refactor(doc): improve documentation based on MR feedback
Toggle commit list-
c91533bb...94974e2c - 103 commits from branch
- Resolved by Ash McKenzie
- Resolved by Fabio Huser
changed milestone to %12.7
mentioned in commit 814709c4
mentioned in issue #16647 (closed)
added docsfeature documentation labels
added Technical Writing label
mentioned in commit 7816adee
mentioned in commit siemens/gitlab@ba8ba0eb
mentioned in merge request !22770 (merged)
mentioned in commit 7c6f8d0e
mentioned in commit nachootal/gitlab@1e3b5748
added typemaintenance label