Skip to content
Snippets Groups Projects

Implement application appearance API

Merged Fabio Huser requested to merge siemens/gitlab:feat/appearance-api into master
All threads resolved!

What does this MR do?

This MR implements a new API endpoint /application/appearance, which makes the content of /admin/appearance accessible via API.

While the /application/settings API endpoint already exposes most of the configuration options, there was no automated way to change the appearance settings.

Addresses #16647 (closed)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Fabio Huser

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Manoj M J
  • Manoj M J
  • Manoj M J
  • Manoj M J
  • Manoj M J
  • unassigned @manojmj

  • Fabio Huser added 2387 commits

    added 2387 commits

    • dee56197...0492b97d - 2385 commits from branch gitlab-org:master
    • 6ece29f6 - feat(api): implement application appearance API
    • 257dd0bf - docs(changelog): add changelog entry for appearance API endpoint

    Compare with previous version

  • Fabio Huser added 1 commit

    added 1 commit

    • a7d557bc - docs(changelog): add changelog entry for appearance API endpoint

    Compare with previous version

  • Manoj M J resolved all threads

    resolved all threads

  • Manoj M J approved this merge request

    approved this merge request

  • assigned to @eread

  • added backend label

  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read assigned to @fh1ch and unassigned @eread

    assigned to @fh1ch and unassigned @eread

  • Fabio Huser added 1 commit

    added 1 commit

    • 0d04d9cf - Apply suggestion to doc/api/appearance.md

    Compare with previous version

  • Fabio Huser added 1 commit

    added 1 commit

    • 2b4ba521 - Apply suggestion to doc/api/appearance.md

    Compare with previous version

  • Fabio Huser added 1 commit

    added 1 commit

    • 10b5cb3c - Apply suggestion to doc/api/appearance.md

    Compare with previous version

  • mentioned in merge request gitlab-docs!667 (merged)

  • Fabio Huser added 1 commit

    added 1 commit

    • 06e56562 - Apply suggestion to doc/api/api_resources.md

    Compare with previous version

  • Fabio Huser added 1039 commits

    added 1039 commits

    • 06e56562...9ba82eae - 1036 commits from branch gitlab-org:master
    • a82eb1fc - feat(api): implement application appearance API
    • 32b4f22e - docs(changelog): add changelog entry for appearance API endpoint
    • c8007e09 - refactor(doc): improve documentation based on MR feedback

    Compare with previous version

  • Evan Read approved this merge request

    approved this merge request

  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read
  • Evan Read unapproved this merge request

    unapproved this merge request

  • Fabio Huser added 1 commit

    added 1 commit

    • 1b2dd14c - Apply suggestion to doc/api/appearance.md

    Compare with previous version

  • Fabio Huser added 1 commit

    added 1 commit

    • 1ccf2e04 - Apply suggestion to doc/api/appearance.md

    Compare with previous version

  • Fabio Huser resolved all threads

    resolved all threads

  • Fabio Huser added 1 commit

    added 1 commit

    • 8ce4a81e - Apply suggestion to lib/api/appearance.rb

    Compare with previous version

  • Fabio Huser added 1 commit

    added 1 commit

    • c91533bb - Apply suggestion to lib/api/appearance.rb

    Compare with previous version

  • Fabio Huser added 106 commits

    added 106 commits

    • c91533bb...94974e2c - 103 commits from branch gitlab-org:master
    • 3ea073f1 - feat(api): implement application appearance API
    • 35cc26e5 - docs(changelog): add changelog entry for appearance API endpoint
    • c787cb8e - refactor(doc): improve documentation based on MR feedback

    Compare with previous version

  • Setting ~"Category:Authentication and Authorization" based on ~"group::access".

  • Evan Read approved this merge request

    approved this merge request

  • Ash McKenzie
  • Ash McKenzie resolved all threads

    resolved all threads

  • Ash McKenzie approved this merge request

    approved this merge request

  • Ash McKenzie changed milestone to %12.7

    changed milestone to %12.7

  • merged

  • Ash McKenzie mentioned in commit 814709c4

    mentioned in commit 814709c4

  • mentioned in issue #16647 (closed)

  • Fabio Huser resolved all threads

    resolved all threads

  • mentioned in commit 7816adee

  • Fabio Huser mentioned in merge request !22770 (merged)

    mentioned in merge request !22770 (merged)

  • Fabio Huser mentioned in commit 7c6f8d0e

    mentioned in commit 7c6f8d0e

  • Please register or sign in to reply
    Loading