Skip to content

Next

Projects
Groups
Snippets
Help

Loading...
Sign in / Register

Project overview
Repository
Issues 51,773
Merge Requests 854
- Merge Requests 854
CI / CD
Security & Compliance
Packages
Snippets
- Snippets
Members
- Members

Collapse sidebar

Activity
Graph
Charts
Create a new issue
Jobs
Commits
Issue Boards

GitLab.org
GitLab
Merge Requests
!20154

Open

Opened Nov 14, 2019 by Vladimir Shushlin @vshushlin🔴10 of 12 tasks completed10/12 tasks

Report abuse

GitLab Pages - Storage size Limitations by Project or Group - backend

Overview 48
Commits 3
Pipelines 24
Changes 26

What does this MR do?

Backend implementation for #16610

The columns were added in !17231 (merged) And closest_setting helper was added in !17769 (diffs)

The code is extracted to ee directory because we want to put it under GitLab Premium tier.

Changelog is not added since frontend will be merged later.
This MR also adds validations for max_pages/artifacts_size, which was forgotten earlier

Screenshots

Does this MR meet the acceptance criteria?

Conformity

Changelog entry
Documentation (if required)
Code review guidelines
Merge request performance guidelines
Style guides
Database guides
Separation of EE specific content

Availability and Testing

Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

Label as security and @ mention @gitlab-com/gl-security/appsec
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
Security reports checked/validated by a reviewer from the AppSec team

## What does this MR do?

Backend implementation for https://gitlab.com/gitlab-org/gitlab/issues/16610

The columns were added in https://gitlab.com/gitlab-org/gitlab/merge_requests/17231
And `closest_setting` helper was added in https://gitlab.com/gitlab-org/gitlab/merge_requests/17769/diffs#3a53dc15ec7c51cffe40f034fbab5a9f3d61b351_319_319

The code is extracted to `ee` directory because we want to put it under ~"GitLab Premium" tier.

* Changelog is not added since frontend will be merged later.
* This MR also adds validations for max_pages/artifacts_size, which was forgotten earlier

## Screenshots

## Does this MR meet the acceptance criteria?

### Conformity

- [x] [Changelog entry](https://docs.gitlab.com/ee/development/changelog.html) 
- [ ] [Documentation](https://docs.gitlab.com/ee/development/documentation/workflow.html) ([if required](https://docs.gitlab.com/ee/development/documentation/workflow.html#when-documentation-is-required))
- [x] [Code review guidelines](https://docs.gitlab.com/ee/development/code_review.html)
- [x] [Merge request performance guidelines](https://docs.gitlab.com/ee/development/merge_request_performance_guidelines.html)
- [x] [Style guides](https://gitlab.com/gitlab-org/gitlab-ee/blob/master/doc/development/contributing/style_guides.md)
- [x] [Database guides](https://docs.gitlab.com/ee/development/README.html#database-guides)
- [x] [Separation of EE specific content](https://docs.gitlab.com/ee/development/ee_features.html#separation-of-ee-code)

### Availability and Testing

- [x] [Review and add/update tests for this feature/bug](https://docs.gitlab.com/ee/development/testing_guide/index.html). Consider [all test levels](https://docs.gitlab.com/ee/development/testing_guide/testing_levels.html). See the [Test Planning Process](https://about.gitlab.com/handbook/engineering/quality/test-engineering).
- [x] [Tested in all supported browsers](https://docs.gitlab.com/ee/install/requirements.html#supported-web-browsers)

### Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in [the security review guidelines](https://about.gitlab.com/handbook/engineering/security/#when-to-request-a-security-review):

- [x] Label as ~security and @ mention `@gitlab-com/gl-security/appsec`
- [x] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [ ] Security reports checked/validated by a reviewer from the AppSec team

Edited Dec 10, 2019 by Vladimir Shushlin

Check out, review, and merge locally

Step 1. Fetch and check out the branch for this merge request

git fetch origin
git checkout -b "16610-gitlab-pages-storage-size-limitations-by-project-or-group-4" "origin/16610-gitlab-pages-storage-size-limitations-by-project-or-group-4"

Step 2. Review the changes locally

Step 3. Merge the branch and fix any conflicts that come up

git fetch origin
git checkout "origin/master"
git merge --no-ff "16610-gitlab-pages-storage-size-limitations-by-project-or-group-4"

Step 4. Push the result of the merge to GitLab

git push origin "master"

Note that pushing to GitLab requires write access to this repository.

Tip: You can also checkout merge requests locally by following these guidelines.

Assignee

Assign to

12.6

Milestone

Assign milestone

Time tracking

21

Labels

Category:Pages Deliverable Enterprise Edition GitLab Premium In dev P2 Release [DEPRECATED] S2 UX UX ready [DEPRECATED] database database::review pending devops::release feature frontend group::release management internal customer missed-deliverable missed:12.4 missed:12.5 workflow::In dev

Assign labels

View project labels

Reference: gitlab-org/gitlab!20154