Skip to content

Update information and button text for deployment footer

Sarah Groff Hennigh-Palermo requested to merge 25351-texts-and-structure into master

What does this MR do?

This MR updates the text and button text for the deployment footer to match the table shown in #25351 (closed). This involves also refactoring the deployment tests, as they were predicated on a certain file setup and failed when components were extracted. The main changes are:

  • Adding isManual, isCurrent, canBeManuallyDeployed, and computedDeploymentStatus to app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment.vue

  • Refactoring the deployment.vue file to remove the code abstracted in app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_info.vue, app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_stop_button.vue, and app/assets/javascripts/vue_merge_request_widget/components/deployment/deployment_view_button.vue

  • Placing deployment and its subcomponents into a separate directory

  • Adding constants for the deplpyment statuses app/assets/javascripts/vue_merge_request_widget/components/deployment/constants.js and using them in test files: ee/spec/javascripts/vue_mr_widget/ee_mr_widget_options_spec.js, spec/frontend/vue_mr_widget/deployment/deployment_mock_data.js, and spec/javascripts/vue_mr_widget/mr_widget_options_spec.js

It is the first step in addressing #25351 (closed). The second will be to add in the manual deploy and re-deploy buttons.

Screenshots

Screen_Shot_2019-10-21_at_6.53.20_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Edited by Sarah Groff Hennigh-Palermo

Merge request reports