Review app links are not correct for deploying/pending manual tasks
Problem to solve
Coming from https://gitlab.com/gitlab-org/gitlab-ce/issues/53578#note_116690688:
- Deploying to review-docs/fix-tags-for-envs
- Failed to deploy to review/fix-tags-for-envs "Deploying to review-docs/fix-tags-for-envs" is a manual job, that does not happen until user triggers the job, however, we state it as "Deploying".
Also, gitlab-com/www-gitlab-com!20981 (merged):
- Staging deployment (which is a manual task that has not yet happened) shows it will deploy so it seems to understand that at least in this case, but also shows the view app link which doesn't make sense if it hasn't deployed yet.
Proposal
Update the copy and action buttons for the pipeline states as seen below:
| State | Description | Copy | Action buttons |
|---|---|---|---|
| will_deploy | Future deployments that a pipeline will execute (i.e. Jobs with environment: ..., when: on_success/on_failure/delayed/always) | Will deploy to [env] | If previous deployment exists, show "View previous app" |
| manual_deploy | Future deployments that a pipeline will allow users to execute manually (i.e. Jobs with environment: ..., when: manual) | Can deploy manually to [env] | If previous deployment exists, show "View previous app" and "deploy" |
| deploying | Running deployments in a pipeline | Deploying to [env] | If previous deployment exists, show "View previous app" |
| success | Finished deployments in a pipeline, and the result is success. | Deployed to [env] | Show "View app" button |
| failed | Finished deployments in a pipeline, and the result is failed. | Failed to deploy to [env] | If previous deployment exists, show "View previous app" button and "re-deploy" |
| canceled | Canceled deployments in a pipeline | Canceled to deploy to [env] | If previous deployment exists, show "View previous app" button |
NOTE:
- "review" and "stop" buttons are basically shown if "View (previous) app" button is available.
What does success look like, and how can we measure that?
We improve the messages displayed to the user.