Return merge-request state in API
What does this MR do?
- expose
cannot_be_merged
andmergeable_discussions_state
in Show an MR API.
re: #30161 (closed)
Screenshots
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation created/updated or follow-up review issue created -
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Merge request reports
Activity
added Community contribution label
added devopscreate groupsource code labels
cc/ @jramsay, @nick.thomas
- Resolved by James Ramsay (ex-GitLab)
Thank you @briankabiro
776 776 expose :squash 777 777 778 778 expose :task_completion_status 779 780 expose :cannot_be_merged?, as: :has_conflicts 781 expose :mergeable_discussions_state?, as: :mergeable_discussions_state do |merge_request| changed this line in version 2 of the diff
added 2 commits
- Resolved by Bob Van Landuyt
- Resolved by Bob Van Landuyt
@m_gill who from the Source Code group should be coach for this contribution since @nick.thomas is OOO?
Edited by James Ramsay (ex-GitLab)
assigned to @reprazent
- Resolved by Brian Kabiro
- Resolved by Brian Kabiro
Could we also add these new attributes to the request spec so we're sure they're included everywhere
- Resolved by Bob Van Landuyt
Thanks a lot @briankabiro
.Left a few comments. Please
@-mention
me when you're ready for another pass.
assigned to @briankabiro and unassigned @reprazent
Also, feel free to add a changelog to take credit for your work!
Thank you very much @briankabiro!
assigned to @reprazent
mentioned in commit b021f889
marked the checklist item Changelog entry as completed
mentioned in issue #30161 (closed)
changed milestone to %12.5
mentioned in commit Dalahro/gitlab@4d1a3d31
This merge request has been deployed to the GitLab.com environment
gstg
in GitLab auto-deploy version12.5.201910311210-d5886f651a4.3ea7cde5d39
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd-cny
in GitLab auto-deploy version12.5.201910312010-60c5d4225eb.efb9aedada9
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowcanary label and removed workflowstaging label
This merge request has been deployed to the GitLab.com environment
gprd
in GitLab auto-deploy version12.5.201911051208-6ed176c0af2.b8eace52b50
.A list of all the deployed commits can be found here.
If this message is incorrect, please create an issue in the Release Tools project.added workflowproduction label and removed workflowcanary label
mentioned in merge request !19982 (closed)