Resolve "Enable Cloud Run on GKE cluster creation"

What does this MR do?

Allows users to create Kubernetes clusters on GCP using Cloud Run on GKE to pre-install Knative.

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

Screenshots

Closes #27502 (closed)

This MR was originally reviewed as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31790 and moved here per https://gitlab.com/gitlab-org/gitlab-ee/issues/13304

changed milestone to %12.3

added Alliances Category:Kubernetes Management Deliverable backend devopsconfigure [DEPRECATED] direction frontend typefeature workflowin review + 1 deleted label

unmarked as a Work In Progress

marked the checklist item Changelog entry as completed

marked the checklist item Documentation created/updated or follow-up review issue created as completed

marked the checklist item Code review guidelines as completed

marked the checklist item Merge request performance guidelines as completed

marked the checklist item Style guides as completed

marked the checklist item Database guides as completed

marked the checklist item Separation of EE specific content as completed

marked the checklist item Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. as completed

assigned to @mattkasa

added 3 commits

• 7914db10 - Fix setting cluster application statuses
• 3a6ede4b - Add cloud_run column for Cloud Run on GKE
• 79e8b3f5 - Add Cloud Run on GKE feature to cluster creation

Compare with previous version

Moved from https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31790

/cc @tkuah

assigned to @tkuah

changed the description

added database databasereview pending labels

	2 Warnings
	This merge request is quite big (more than 515 lines changed), please consider splitting it into multiple merge requests.
	This merge request changed files with disabled eslint rules. Please consider fixing them.

	1 Message
	This merge request adds or changes files that require a review from the Database team.

Disabled eslint rules

The following files have disabled eslint rules. Please consider fixing them:

• app/assets/javascripts/clusters/components/application_row.vue

Run the following command for more details

node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \
  'app/assets/javascripts/clusters/components/application_row.vue'

This merge request requires a database review. To make sure these changes are reviewed, take the following steps:

1. Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
2. Use the Database changes checklist template or add the appropriate items to the MR description.
3. Assign and mention the database reviewer suggested by Reviewer Roulette.

The following files require a review from the Database team:

• db/migrate/20190905140605_add_cloud_run_to_clusters_providers_gcp.rb
• db/migrate/20190919162036_add_index_to_clusters_providers_gcp_on_cloud_run.rb
• db/schema.rb

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
frontend	André Luís (@andr3)	Fatih Acet (@fatihacet)
backend	Felipe Artur (@felipe_artur)	Robert Speicher (@rspeicher)
database	Adam Hegyi (@ahegyi)	Andreas Brandl (@abrandl)

Generated by Danger

Thanks @mattkasa ! Looking great now, just some minor comments. Do you want to send it to Front-end review as well ?

unassigned @tkuah

mentioned in issue gl-retrospectives/configure#20 (closed)

added 1 commit

• 0a2066b2 - Document `pre_installed` application state

Compare with previous version

@timzallmann you reviewed this MR as https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31790 but wanted to send it back to you now that it's open against the combined gitlab repo

assigned to @tkuah and @timzallmann and unassigned @mattkasa

added 1 commit

• b27f10d2 - Update changelog with gitlab repo MR number

Compare with previous version

assigned to @mattkasa and unassigned @tkuah

approved this merge request

FE LGTM, Final approval done! Leaving the merge to BE final review

unassigned @timzallmann

added 684 commits

• b27f10d2...5341ef1b - 681 commits from branch master
• 16c13a56 - Fix setting cluster application statuses
• 38622266 - Add cloud_run column for Cloud Run on GKE
• 230a0139 - Add Cloud Run on GKE feature to cluster creation

Compare with previous version

changed milestone to %12.4

resolved all threads

@tkuah I think I've addressed everything, but maybe we can review together later if there's anything else.

assigned to @tkuah and unassigned @mattkasa

This was approved by DB databaseapproved in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31790

added databaseapproved label and removed databasereview pending label

There's still some failing specs:

• https://gitlab.com/gitlab-org/gitlab/-/jobs/299589072

• https://gitlab.com/gitlab-org/gitlab/-/jobs/299589145

added 7 commits

• 230a0139...ae561839 - 4 commits from branch master
• 6e48e763 - Fix setting cluster application statuses
• f01c4eba - Add cloud_run column for Cloud Run on GKE
• 9144ed77 - Add Cloud Run on GKE feature to cluster creation

Compare with previous version

Great work @mattkasa - just a few final things Thanks for persisting through this

assigned to @mattkasa and unassigned @tkuah

added 1 commit

• b8beb52e - Add Cloud Run spec for FinalizeCreationService

Compare with previous version

changed the description

added 1 commit

• 010206a9 - Split CloudRun migration into column and index

Compare with previous version

resolved all threads

@mattkasa Something is up with https://gitlab.com/gitlab-org/gitlab/-/jobs/299682760 - perhaps a rebase might fix this

added 9 commits

• 010206a9...b66e5957 - 6 commits from branch master
• 072c0188 - Fix setting cluster application statuses
• 894d7bf9 - Add cloud_run column for Cloud Run on GKE
• 2140e855 - Add Cloud Run on GKE feature to cluster creation

Compare with previous version

added 1 commit

• bcf142af - Add Cloud Run on GKE feature to cluster creation

Compare with previous version

@tkuah pipeline is passing now

assigned to @tkuah and unassigned @mattkasa

approved this merge request

merged

mentioned in commit eb82ce60

LGTM - Thanks for this MR @mattkasa

This merge request has been deployed to the GitLab.com environment gstg in GitLab auto-deploy version 12.4.201910011210-d42717d3ad0.477f92dfa6a.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowstaging label and removed workflowin review label

This merge request has been deployed to the GitLab.com environment gprd-cny in GitLab auto-deploy version 12.4.201910011210-d42717d3ad0.477f92dfa6a.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowcanary label and removed workflowstaging label

This merge request has been deployed to the GitLab.com environment gprd in GitLab auto-deploy version 12.4.201910021004-f79c1794977.391a41dff5a.

A list of all the deployed commits can be found here.

---

If this message is incorrect, please create an issue in the Release Tools project.

added workflowproduction label and removed workflowcanary label

added groupconfigure [DEPRECATED] label and removed 1 deleted label

mentioned in issue gitlab-runner#5028

changed the description

added groupenvironments label and removed groupconfigure [DEPRECATED] label