Enable ES web indexing by default

What does this MR do?

Enables the feature flag for ES web indexing by default, and slightly improves the button in the admin UI.

Docs changes are in https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/31972

Ref: https://gitlab.com/gitlab-org/gitlab-ee/issues/12712

Screenshots

Initial state:

After enabling Elasticsearch indexing and submitting the form:

Does this MR meet the acceptance criteria?

Conformity

• Changelog entry
• Documentation created/updated or follow-up review issue created
• Code review guidelines
• Merge request performance guidelines
• Style guides
• [-] Database guides
• Separation of EE specific content

Performance and Testing

• Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
• [-] Tested in all supported browsers

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

• [-] Label as security and @ mention @gitlab-com/gl-security/appsec
• [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
• [-] Security reports checked/validated by a reviewer from the AppSec team

changed milestone to %12.3

added Category:Global Search Deliverable Enterprise Edition advanced search backend devopscreate direction feature flag groupeditor [DEPRECATED] typefeature workflowin dev labels

added 1 commit

• b0de073a - Remove feature flag for ES web indexing button

Compare with previous version

changed title from Enable/document ES web indexing to Enable ES web indexing

changed the description

marked the checklist item Changelog entry as completed

marked the checklist item Separation of EE specific content as completed

removed workflowin dev label

	1 Message
	CHANGELOG missing: If this merge request doesn’t need a CHANGELOG entry, feel free to ignore this message. You can create one with: bin/changelog -m 15390 "Enable ES web indexing by default" Note: Merge requests with ~backstage, ci-build, meta do not trigger this check.

Reviewer roulette

Changes that require review have been detected! A merge request is normally reviewed by both a reviewer and a maintainer in its primary category (e.g. frontend or backend), and by a maintainer in all other categories.

To spread load more evenly across eligible reviewers, Danger has randomly picked a candidate for each review slot. Feel free to override this selection if you think someone else would be better-suited, or the chosen person is unavailable.

Once you've decided who will review this merge request, mention them as you normally would! Danger does not (yet?) automatically notify them for you.

Category	Reviewer	Maintainer
backend	David Wilkins (@dwilkins)	Robert Speicher (@rspeicher)
frontend	Martin Hanzel (@arthanzel)	Mike Greiling (@mikegreiling)

Generated by Danger

mentioned in issue #13641 (closed)

@lulalala do you want to give this a review? :)

assigned to @lulalala

added 1 commit

• 5b245e4a - Remove feature flag for ES web indexing button

Compare with previous version

changed title from Enable ES web indexing to Remove feature flag for ES web indexing button

mentioned in issue #12712 (closed)

added 749 commits

• 5b245e4a...428c5947 - 747 commits from branch master
• 53141085 - Enable ES web indexing by default
• fa57a6e7 - Improve ES web indexing button

Compare with previous version

changed the description

changed title from Remove feature flag for ES web indexing button to Enable ES web indexing by default

@jareko @marcel.amirault @phikai this is now changed as discussed at https://gitlab.com/gitlab-org/gitlab-ee/issues/12712#note_206419893, see the screenshots in the MR description.

As mentioned the form has to be submitted first before the button becomes visible, I didn't want to get too fancy and add any JS :)