Skip to content

Customizable cycle analytics - Custom stage form ui

Ezekiel Kigbo requested to merge 13076-cycle-analytics-add-stage-form-ee into master

What does this MR do?

isComplete = false isComplete = true
Screen_Shot_2019-09-16_at_1.10.36_pm Screen_Shot_2019-09-16_at_1.15.29_pm
Label event selected Start label selected Start event changed
Screen_Shot_2019-09-16_at_1.14.58_pm Screen_Shot_2019-09-16_at_1.15.17_pm Screen_Shot_2019-09-16_at_2.07.31_pm

️ Blocked by:

Implements the custom stage for UI for #13076 (closed)

  • Start event
    • Filter the initial request for can_be_start_event
  • Stop event
    • disabled until a start event is selected
    • displays an error and clears the stop event if a new start event is chosen that is not compatible
  • Optional field for extra parameter
    • Currently label fields are the only fields that will require an extra parameter
    • Uses Single label selector
  • Add / Save stage button
    • Emit a submit event
  • Cancel button
    • Clear the values and close the form
  • Follow up added to migrate this to vuex

CE Backport

CE Backport

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by 🤖 GitLab Bot 🤖

Merge request reports