Skip to content

Customisable Cycle Analytics - Single label selector

Ezekiel Kigbo requested to merge 13076-single-label-selector into master

What does this MR do?

As part of #13076 (closed), adds a single label dropdown, the dropdown takes a list of labels and emits events when clicked and also when cleared.

Note: Selected label styling

I originally intended to use the label component from gitlab ui to match the designs when an option is selected, but with the introduction of the color property validator the component now expects to receive the color as a string not hexadecimal. This component will be used to render labels retrieved from the backend which currently return the color values as hexadecimal.

Screenshots

Default state With a selection With a long label Dropdown open
Screen_Shot_2019-08-31_at_12.45.00_am Screen_Shot_2019-08-31_at_12.45.47_am Screen_Shot_2019-08-31_at_12.45.18_am Screen_Shot_2019-08-31_at_12.45.28_am

Does this MR meet the acceptance criteria?

Conformity

Performance and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Closes #13076 (closed)

Edited by 🤖 GitLab Bot 🤖

Merge request reports