Remove feature flag `issue_zoom_integration`
In !16609 (merged) we've added the feature flag issue_zoom_integration
.
Let's remove it after we've completed testing.
-
Remove feature flag flag from the code base
!17787 (merged) -
Remove from
staging
via/chatops run feature delete issue_zoom_integration --staging
-
Remove from
production
via/chatops run feature delete issue_zoom_integration
Related to #31103 (closed)
Designs
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- Peter Leitzen changed milestone to %12.4
changed milestone to %12.4
- Peter Leitzen added backstage [DEPRECATED] feature flag grouprespond labels
added backstage [DEPRECATED] feature flag grouprespond labels
- Author Maintainer
Enabled on
staging
via/chatops run feature set issue_zoom_integration true --staging
- 🤖 GitLab Bot 🤖 added [deprecated] Accepting merge requests label
added [deprecated] Accepting merge requests label
- Maintainer
Setting devopsmonitor based on ~"group::health".
- 🤖 GitLab Bot 🤖 added devopsmonitor label
added devopsmonitor label
- Contributor
I'm going to label this as feature since it will be enabling a feature.
- Seth Engelhard added typefeature label and removed backstage [DEPRECATED] label
added typefeature label and removed backstage [DEPRECATED] label
- Contributor
@splattael I believe this is now ready for development. I'll label it as such.
1 Collapse replies - Author Maintainer
@sengelhard Yes, thank you
- Seth Engelhard added workflowready for development label
added workflowready for development label
- Author Maintainer
Hey @allison.browne
Can you take care of this one?
It's basically removing the feature flag
issue_zoom_integration
fromstub_feature_flags(issue_zoom_integration: false)
|
/zoom| ✓ | | | Add Zoom meeting to this issue. ([Introduced in GitLab 12.3](https://gitlab.com/gitlab-org/gitlab/merge_requests/16609) enabled by feature flag
issue_zoom_integration) |
|
/remove_zoom| ✓ | | | Remove Zoom meeting from this issue. ([Introduced in GitLab 12.3](https://gitlab.com/gitlab-org/gitlab/merge_requests/16609) enabled by feature flag
issue_zoom_integration) |
Feature.enabled?(:issue_zoom_integration, project)
stub_feature_flags(issue_zoom_integration: false)
stub_feature_flags(issue_zoom_integration: false)
For any questions, I happily assist
- Peter Leitzen assigned to @allison.browne
assigned to @allison.browne
- Contributor
@allison.browne - this will be your first
gitlab
repo issue. @ck3g can help you with this once you're ready. - Maintainer
Thanks @splattael and @sengelhard. - 🤖 GitLab Bot 🤖 removed [deprecated] Accepting merge requests label
removed [deprecated] Accepting merge requests label
- Peter Leitzen mentioned in issue #31103 (closed)
mentioned in issue #31103 (closed)
- Allison Browne mentioned in merge request !17786 (closed)
mentioned in merge request !17786 (closed)
- Allison Browne mentioned in merge request !17787 (merged)
mentioned in merge request !17787 (merged)
- Allison Browne added workflowin dev label and removed workflowready for development label
added workflowin dev label and removed workflowready for development label
- Peter Leitzen changed the description
changed the description
- Peter Leitzen marked the checklist item Remove feature flag flag from the code base
!17787 (merged) as completedmarked the checklist item Remove feature flag flag from the code base
!17787 (merged) as completed - Maintainer
@splattael/@ck3g, should I run those
/chatops
commands in a specific slack channel? Collapse replies - Author Maintainer
For visibility, I usually run the
/chatops
commands for theproduction
environment in#production
.For
staging
, I often use#s_monitor
. - Author Maintainer
@allison.browne Make sure you run corresponding
/chatops
commands after they have been deployed to the corresponding environments. First, it will bestaging
, thancanary
and thenproduction
.(Please excuse the double post)
- Contributor
For visibility, I usually run the
/chatops
commands for theproduction
environment in#production
.For
staging
, I often use#s_monitor
.This seems like a great practice and we should document it if it isn't already.
- Maintainer
@sengelhard, do you think we should document this just for our team? If so I can add it to https://about.gitlab.com/handbook/engineering/development/ops/monitor/
- Maintainer
I ran into a permissions error trying to run the
/chatops
commands to check deploy status as documented here:Should I fill out an access request to request permissions or is that restricted to a certain type of user?
- Contributor
I ran into a permissions error trying to run the
/chatops
commands to check deploy statusIt looks like this was resolved by
@splattael
- let me know if it still doesn't work for you.@sengelhard, do you think we should document this just for our team? If so I can add it to https://about.gitlab.com/handbook/engineering/development/ops/monitor/
I think this should be something that we propose as a standard across the board. If you can open an MR to add the recommendation here, I'll help socialize the proposal: https://docs.gitlab.com/ee/development/feature_flags/development.html
- Maintainer
MR here: !18229 (merged)
- Allison Browne added workflowverification label and removed workflowin dev label
added workflowverification label and removed workflowin dev label
- Allison Browne marked the checklist item Remove from
staging
via/chatops run feature delete issue_zoom_integration --staging
as completedmarked the checklist item Remove from
staging
via/chatops run feature delete issue_zoom_integration --staging
as completed - Allison Browne marked the checklist item Remove from
production
via/chatops run feature delete issue_zoom_integration
as completedmarked the checklist item Remove from
production
via/chatops run feature delete issue_zoom_integration
as completed - Maintainer
Async issue update
- Please provide a quick summary of the current status (one sentence). All tasks in Production and ready for verification. Still planning to open an MR for documenting chatops chat rooms to use.
- When do you predict this feature to be ready for maintainer review? Code has been reviewed - ready for feature verification
- Are there any opportunities to further break the issue or merge request into smaller pieces (if applicable)? No
1 - Allison Browne mentioned in merge request !18229 (merged)
mentioned in merge request !18229 (merged)
- Allison Browne mentioned in merge request !17973 (merged)
mentioned in merge request !17973 (merged)
- Maintainer
Can this issue be closed? :)
- Allison Browne closed
closed
- Sam Goldstein mentioned in issue gitlab-com/www-gitlab-com#9140 (closed)
mentioned in issue gitlab-com/www-gitlab-com#9140 (closed)