Make Puma enabled by default for everyone

Enable on gitlab.com in release X
Set as opt-in in Omnibus/Charts in release X. Announce Unicorn as deprecated in X+3, will likely become the default next release.
Provided gitlab.com is stable, set as opt-out for Omnibus/Charts in release X+1.
Remove the opt-out flag in X+3, provided feedback has been positive.

cc @ljlane

@joshlambert

I invited you to Puma Sync meeting. Lets discuss the timeline, zero-downtime and steps to finalise that story tomorrow.

@joshlambert Where did we land on your proposed timeline above? We have Puma added to Omnibus and working on an MR to add it to the charts.

Set as opt-in in Omnibus/Charts in release X. Announce Unicorn as deprecated in X+3, will likely become the default next release.

If Puma becomes opt-in in the charts in 12.9, the above proposal will have it becoming the default by %13.2 rather than the original goal of %13.0

Provided gitlab.com is stable, set as opt-out for Omnibus/Charts in release X+1

Is gitlab.com considered stable now?

mentioned in epic gitlab-com/gl-infra&78 (closed)

marked the checklist item Allow to update db_pool: omnibus-gitlab#4631 (closed), as completed

mentioned in issue #35371 (closed)

changed the description

mentioned in issue omnibus-gitlab#3896 (closed)

This epic currently has groupdistribution and %12.6 but it's unclear to me what needs to be done by the Distribution team for %12.6. @craig-gomes @ayufan can you comment?

I don't think that %12.6 is valid, but it seems the wrap-up of on by default is for groupdistribution as it requires:

updating defaults in Omnibus,
updating HA documentation how to use new health-checks,
deprecate Unicorn,
adapt Cloud-Native to offer and use Puma as well,
likely this should be done in %13.0

Okay, we can get issues created and targeted for %13.0. Are you aware of anything that is blocking groupdistribution from moving forward with this besides the milestone?

@ayufan @twk3 @WarheadsSE What is the user impact of enabling Puma by default? I'm referring to negative impact as in any manual changes required when upgrading. And the reason I'm asking is to understand whether this change needs to happen in a major release of GitLab.

@ljlane

If we change default unless user made their own modifications to unicron[' it will not be noticeable change, as application will restart to use Puma. There are the following problems:

If user made their own changes to unicorn[' it will break, as puma[' has it's own config,
It affects HA: we do not offer zero-downtime deployments for Puma for single node,
To have HA: we require to configure health-check and perform rolling update of GitLab.

No, I don't think that we can make this change in minor release. It is too big of a change to do it like this. We would require to:

Start using health-check for having HA config,
Update puma[' to reflect unicorn['.

I think that it is simply too big of a change.

cc @craig-gomes

@ljlane Effectively, very similar within the Helm charts. We'd have items in the CheckConfig pattern to watch for having Unicorn configured, but Puma in use. Most of the settings will be similar, and even translate without interaction. Some settings, like worker processes, threads, and resulting memory configuration.

When we talk about enabling Puma by default are we talking about just new installs or upgrades too? Maybe I'm not seeing the big picture here, but if it's an upgrade couldn't we just leave their unicorn settings in place and recommend they move to Puma some time in the future? Unicorn will be supported until 14.0.

In absence of previous settings, then it would be Puma by default.

@craig-gomes I think we need to enable it on upgrades as well, in an opt-in fashion in 13.0. Otherwise we have to wait an entire year, which means we will have to support two different architectures for a long long time.

But we if we are concerned about the timeline (it is definitely fast) then let's have that discussion about alternative plans.

changed milestone to %13.0

added Deliverable + 1 deleted label

added priority1 + 1 deleted label

added direction priority2 + 1 deleted label and removed priority1 + 1 deleted label

marked the checklist item Update and close benchmarks: https://gitlab.com/gitlab-org/gitlab-ce/issues/62878, https://gitlab.com/gitlab-org/gitlab-ce/issues/62876. as completed

marked the checklist item Handle zero-downtime deployments with Puma: omnibus-gitlab#4739 (closed) as completed

removed Deliverable + 1 deleted label

marked the checklist item Ensure that this runs on gitlab.com for at least one full release, as completed

changed the description

marked the checklist item Improve graceful restart handling in Omnibus: omnibus-gitlab#4756 (closed) as completed

marked the checklist item Improve graceful restart handling in Omnibus: omnibus-gitlab#4756 (closed) as incomplete

changed the description

marked the checklist item Improve Puma request handling in multi-threaded mode: #36858 (closed) as completed

marked the checklist item Do full restart of Puma during deployment: omnibus-gitlab#4928 (closed) as completed

marked the checklist item Improve graceful restart handling in Omnibus: omnibus-gitlab#4756 (closed) as completed

Make Puma enabled by default for everyone

Designs

Child items ...

Activity

Make Puma enabled by default for everyone

Relates to

Activity