Error message when merging MR if an approver is included in the approvers list both as a group member and as individual user

Summary

Error message is shown when merging MR if an approver is included in the approvers list both as a group member and as individual user.

Steps to reproduce

• create a group group1 and a project project1 inside this group
• create a user user1 and add the user as a member of group1
• go to project Settings > General > Merge request approvals, click Edit, add both user1 and group1 to the list of members, click Add > Update approvers (see the attached screenshot)
• create a new branch in project1 and submit MR from this branch to master with options Delete source branch when merge request is accepted and Squash commits when merge request is accepted enabled
• login as user1, approve the merge request and click Merge. Its status will be changed to Merged, and the message The source branch is being deleted will be shown for some time. If you refresh the page, the error message Merge failed: Failed to squash. Should be done manually.. Please try again. will be shown
• if created MR only has the option Delete source branch when merge request is accepted checked then the error message will be different - Merge failed: Merge request is not mergeable. Please try again.

What is the current bug behavior?

Error messages are shown when merging Merge Requests:

What is the expected correct behavior?

Merge should be completed successfully without any error messages.

Workaround

Remove directly listed approvers that are also members of the same group from the Merge request approvals list.

Relevant logs and/or screenshots

Logs collected when reproducing the issue with both options Delete source branch when merge request is accepted and Squash commits when merge request is accepted enabled.

==> /var/log/gitlab/gitlab-rails/githost.log <==
August 13, 2019 10:19 -> ERROR -> MergeRequests::SquashService error (group1/project1!5): Failed to squash merge request group1/project1!5:
August 13, 2019 10:19 -> ERROR -> MergeRequests::SquashService error (group1/project1!5): Not currently on any branch.
nothing to commit, working tree clean

==> /var/log/gitlab/gitlab-rails/sidekiq.log <==

2019-08-13_10:37:00.12908 2019-08-13T10:37:00.129Z 31316 TID-ovi1sjwfc WARN: {"context":"Job raised exception","job":{"class":"MergeWorker","args":[31,1,{"should_remove_source_branch":true,"commit_message":"Merge branch 'dev6' into 'master'\n\nAdd new file\n\nSee merge request group1/project1!6","squash_commit_message":"Add new file","squash":true}],"retry":3,"queue":"merge","jid":"c5a5adc720b6cc9713e0b61b","created_at":1565692617.7972443,"correlation_id":"OZuK9AIhVc6","enqueued_at":1565692617.801224},"jobstr":"{\"class\":\"MergeWorker\",\"args\":[31,1,{\"should_remove_source_branch\":true,\"commit_message\":\"Merge branch 'dev6' into 'master'\\n\\nAdd new file\\n\\nSee merge request group1/project1!6\",\"squash_commit_message\":\"Add new file\",\"squash\":true}],\"retry\":3,\"queue\":\"merge\",\"jid\":\"c5a5adc720b6cc9713e0b61b\",\"created_at\":1565692617.7972443,\"correlation_id\":\"OZuK9AIhVc6\",\"enqueued_at\":1565692617.801224}"}
2019-08-13_10:37:00.12914 2019-08-13T10:37:00.129Z 31316 TID-ovi1sjwfc WARN: ActiveRecord::RecordNotUnique: PG::UniqueViolation: ERROR:  duplicate key value violates unique constraint "index_approval_merge_request_rules_users_1"
2019-08-13_10:37:00.12915 DETAIL:  Key (approval_merge_request_rule_id, user_id)=(21, 15) already exists.

Full error

2019-08-13_10:37:00.12915 : INSERT INTO "approval_merge_request_rules_users" ("approval_merge_request_rule_id", "user_id") VALUES (21, 15) RETURNING "id"
2019-08-13_10:37:00.12938 2019-08-13T10:37:00.129Z 31316 TID-ovi1sjwfc WARN: /opt/gitlab/embedded/service/gitlab-rails/config/initializers/peek.rb:18:in async_exec_params' 2019-08-13_10:37:00.12939 /opt/gitlab/embedded/service/gitlab-rails/config/initializers/peek.rb:18:in exec_params'
2019-08-13_10:37:00.12939 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql_adapter.rb:611:in block (2 levels) in exec_no_cache' 2019-08-13_10:37:00.12939 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies/interlock.rb:48:in block in permit_concurrent_loads'
2019-08-13_10:37:00.12940 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/concurrency/share_lock.rb:187:in yield_shares' 2019-08-13_10:37:00.12940 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/dependencies/interlock.rb:47:in permit_concurrent_loads'
2019-08-13_10:37:00.12941 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql_adapter.rb:610:in block in exec_no_cache' 2019-08-13_10:37:00.12942 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract_adapter.rb:581:in block (2 levels) in log'
2019-08-13_10:37:00.12943 /opt/gitlab/embedded/lib/ruby/2.6.0/monitor.rb:230:in mon_synchronize' 2019-08-13_10:37:00.12943 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract_adapter.rb:580:in block in log'
2019-08-13_10:37:00.12943 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/notifications/instrumenter.rb:23:in instrument' 2019-08-13_10:37:00.12943 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract_adapter.rb:571:in log'
2019-08-13_10:37:00.12944 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql_adapter.rb:609:in exec_no_cache' 2019-08-13_10:37:00.12944 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql_adapter.rb:596:in execute_and_clear'
2019-08-13_10:37:00.12944 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql/database_statements.rb:81:in exec_query' 2019-08-13_10:37:00.12945 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:130:in exec_insert'
2019-08-13_10:37:00.12945 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/postgresql/database_statements.rb:115:in exec_insert' 2019-08-13_10:37:00.12945 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:162:in insert'
2019-08-13_10:37:00.12946 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/query_cache.rb:21:in insert' 2019-08-13_10:37:00.12946 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/persistence.rb:187:in _insert_record'
2019-08-13_10:37:00.12946 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/persistence.rb:734:in _create_record' 2019-08-13_10:37:00.12946 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/counter_cache.rb:184:in _create_record'
2019-08-13_10:37:00.12947 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/locking/optimistic.rb:70:in _create_record' 2019-08-13_10:37:00.12947 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/attribute_methods/dirty.rb:140:in _create_record'
2019-08-13_10:37:00.12948 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/callbacks.rb:346:in block in _create_record' 2019-08-13_10:37:00.12948 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:98:in run_callbacks'
2019-08-13_10:37:00.12948 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:816:in _run_create_callbacks' 2019-08-13_10:37:00.12948 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/callbacks.rb:346:in _create_record'
2019-08-13_10:37:00.12949 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/timestamp.rb:102:in _create_record' 2019-08-13_10:37:00.12949 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/persistence.rb:705:in create_or_update'
2019-08-13_10:37:00.12949 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/callbacks.rb:342:in block in create_or_update' 2019-08-13_10:37:00.12950 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:132:in run_callbacks'
2019-08-13_10:37:00.12950 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/callbacks.rb:816:in _run_save_callbacks' 2019-08-13_10:37:00.12951 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/callbacks.rb:342:in create_or_update'
2019-08-13_10:37:00.12951 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/persistence.rb:308:in save!' 2019-08-13_10:37:00.12951 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/validations.rb:52:in save!'
2019-08-13_10:37:00.12951 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:315:in block in save!' 2019-08-13_10:37:00.12952 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:387:in block in with_transaction_returning_status'
2019-08-13_10:37:00.12952 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:265:in transaction' 2019-08-13_10:37:00.12953 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:212:in transaction'
2019-08-13_10:37:00.12953 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:385:in with_transaction_returning_status' 2019-08-13_10:37:00.12953 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:315:in save!'
2019-08-13_10:37:00.12953 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/suppressor.rb:48:in save!' 2019-08-13_10:37:00.12954 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/has_many_through_association.rb:84:in save_through_record'
2019-08-13_10:37:00.12954 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/has_many_through_association.rb:45:in insert_record' 2019-08-13_10:37:00.12954 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:439:in block (2 levels) in concat_records'
2019-08-13_10:37:00.12955 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:458:in replace_on_target' 2019-08-13_10:37:00.12955 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:283:in add_to_target'
2019-08-13_10:37:00.12955 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:437:in block in concat_records' 2019-08-13_10:37:00.12956 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:435:in each'
2019-08-13_10:37:00.12956 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:435:in concat_records' 2019-08-13_10:37:00.12956 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/has_many_association.rb:117:in concat_records'
2019-08-13_10:37:00.12956 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/has_many_through_association.rb:27:in concat_records' 2019-08-13_10:37:00.12957 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:120:in block in concat'
2019-08-13_10:37:00.12957 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:135:in block in transaction' 2019-08-13_10:37:00.12958 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:265:in transaction'
2019-08-13_10:37:00.12958 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:212:in transaction' 2019-08-13_10:37:00.12959 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:134:in transaction'
2019-08-13_10:37:00.12959 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:120:in concat' 2019-08-13_10:37:00.12959 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/has_many_through_association.rb:21:in concat'
2019-08-13_10:37:00.12960 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:415:in replace_records' 2019-08-13_10:37:00.12960 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:251:in block in replace'
2019-08-13_10:37:00.12960 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:135:in block in transaction' 2019-08-13_10:37:00.12961 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:265:in transaction'
2019-08-13_10:37:00.12961 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:212:in transaction' 2019-08-13_10:37:00.12961 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:134:in transaction'
2019-08-13_10:37:00.12961 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:251:in replace' 2019-08-13_10:37:00.12962 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/collection_association.rb:41:in writer'
2019-08-13_10:37:00.12962 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/associations/builder/association.rb:116:in users=' 2019-08-13_10:37:00.12963 /opt/gitlab/embedded/service/gitlab-rails/ee/app/services/approval_rules/finalize_service.rb:29:in block in merge_group_members_into_users'
2019-08-13_10:37:00.12963 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/relation/delegation.rb:71:in each' 2019-08-13_10:37:00.12963 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/relation/delegation.rb:71:in each'
2019-08-13_10:37:00.12963 /opt/gitlab/embedded/service/gitlab-rails/ee/app/services/approval_rules/finalize_service.rb:28:in merge_group_members_into_users' 2019-08-13_10:37:00.12964 /opt/gitlab/embedded/service/gitlab-rails/ee/app/services/approval_rules/finalize_service.rb:16:in block in execute'
2019-08-13_10:37:00.12964 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:267:in block in transaction' 2019-08-13_10:37:00.12965 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/transaction.rb:239:in block in within_new_transaction'
2019-08-13_10:37:00.12965 /opt/gitlab/embedded/lib/ruby/2.6.0/monitor.rb:230:in mon_synchronize' 2019-08-13_10:37:00.12965 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/transaction.rb:236:in within_new_transaction'
2019-08-13_10:37:00.12965 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/connection_adapters/abstract/database_statements.rb:267:in transaction' 2019-08-13_10:37:00.12966 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activerecord-5.2.3/lib/active_record/transactions.rb:212:in transaction'
2019-08-13_10:37:00.12966 /opt/gitlab/embedded/service/gitlab-rails/ee/app/services/approval_rules/finalize_service.rb:14:in execute' 2019-08-13_10:37:00.12966 /opt/gitlab/embedded/service/gitlab-rails/ee/app/services/ee/merge_requests/post_merge_service.rb:11:in execute'
2019-08-13_10:37:00.12967 /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/merge_service.rb:90:in after_merge' 2019-08-13_10:37:00.12967 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in block in after_merge'
2019-08-13_10:37:00.12968 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/method_call.rb:36:in measure' 2019-08-13_10:37:00.12968 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in after_merge'
2019-08-13_10:37:00.12968 /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/merge_service.rb:25:in block in execute' 2019-08-13_10:37:00.12968 /opt/gitlab/embedded/service/gitlab-rails/app/models/merge_request.rb:1151:in in_locked_state'
2019-08-13_10:37:00.12968 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in block in in_locked_state' 2019-08-13_10:37:00.12969 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/method_call.rb:36:in measure'
2019-08-13_10:37:00.12969 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in in_locked_state' 2019-08-13_10:37:00.12969 /opt/gitlab/embedded/service/gitlab-rails/app/services/merge_requests/merge_service.rb:23:in execute'
2019-08-13_10:37:00.12969 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in block in execute' 2019-08-13_10:37:00.12972 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/method_call.rb:36:in measure'
2019-08-13_10:37:00.12972 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/instrumentation.rb:161:in execute' 2019-08-13_10:37:00.12972 /opt/gitlab/embedded/service/gitlab-rails/app/workers/merge_worker.rb:12:in perform'
2019-08-13_10:37:00.12972 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:192:in execute_job' 2019-08-13_10:37:00.12973 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:165:in block (2 levels) in process'
2019-08-13_10:37:00.12973 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:128:in block in invoke' 2019-08-13_10:37:00.12973 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/sidekiq_middleware.rb:15:in block in call'
2019-08-13_10:37:00.12973 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/transaction.rb:57:in run' 2019-08-13_10:37:00.12974 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/metrics/sidekiq_middleware.rb:15:in call'
2019-08-13_10:37:00.12974 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12975 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_status/server_middleware.rb:7:in call'
2019-08-13_10:37:00.12975 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12975 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/correlation_logger.rb:10:in block in call'
2019-08-13_10:37:00.12975 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/gitlab-labkit-0.3.0/lib/labkit/correlation/correlation_id.rb:18:in use_id' 2019-08-13_10:37:00.12975 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/correlation_logger.rb:9:in call'
2019-08-13_10:37:00.12976 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12976 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/batch_loader.rb:7:in call'
2019-08-13_10:37:00.12976 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12976 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/request_store_middleware.rb:8:in call'
2019-08-13_10:37:00.12977 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12978 /opt/gitlab/embedded/service/gitlab-rails/lib/gitlab/sidekiq_middleware/memory_killer.rb:18:in call'
2019-08-13_10:37:00.12978 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12978 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sentry-raven-2.9.0/lib/raven/integrations/sidekiq.rb:9:in call'
2019-08-13_10:37:00.12978 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:130:in block in invoke' 2019-08-13_10:37:00.12979 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/middleware/chain.rb:133:in invoke'
2019-08-13_10:37:00.12979 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:164:in block in process' 2019-08-13_10:37:00.12979 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:137:in block (6 levels) in dispatch'
2019-08-13_10:37:00.12979 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:109:in local' 2019-08-13_10:37:00.12980 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:136:in block (5 levels) in dispatch'
2019-08-13_10:37:00.12980 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/rails.rb:43:in block in call' 2019-08-13_10:37:00.12981 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:87:in wrap'
2019-08-13_10:37:00.12981 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/reloader.rb:73:in block in wrap' 2019-08-13_10:37:00.12981 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/execution_wrapper.rb:87:in wrap'
2019-08-13_10:37:00.12981 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/activesupport-5.2.3/lib/active_support/reloader.rb:72:in wrap' 2019-08-13_10:37:00.12982 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/rails.rb:42:in call'
2019-08-13_10:37:00.12982 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:132:in block (4 levels) in dispatch' 2019-08-13_10:37:00.12982 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:250:in stats'
2019-08-13_10:37:00.12982 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:127:in block (3 levels) in dispatch' 2019-08-13_10:37:00.12983 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_logger.rb:8:in call'
2019-08-13_10:37:00.12983 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:126:in block (2 levels) in dispatch' 2019-08-13_10:37:00.12984 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/job_retry.rb:74:in global'
2019-08-13_10:37:00.12984 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:125:in block in dispatch' 2019-08-13_10:37:00.12984 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:48:in with_context'
2019-08-13_10:37:00.12984 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/logging.rb:42:in with_job_hash_context' 2019-08-13_10:37:00.12984 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:124:in dispatch'
2019-08-13_10:37:00.12985 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:163:in process' 2019-08-13_10:37:00.12985 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:83:in process_one'
2019-08-13_10:37:00.12986 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/processor.rb:71:in run' 2019-08-13_10:37:00.12986 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:16:in watchdog'
2019-08-13_10:37:00.12986 /opt/gitlab/embedded/lib/ruby/gems/2.6.0/gems/sidekiq-5.2.7/lib/sidekiq/util.rb:25:in `block in safe_thread'

Output of checks

Results of GitLab environment info

Expand for output related to GitLab environment info

System information
System:     Ubuntu 16.04
Proxy:      no
Current User:   git
Using RVM:  no
Ruby Version:   2.6.3p62
Gem Version:    2.7.9
Bundler Version:1.17.3
Rake Version:   12.3.2
Redis Version:  3.2.12
Git Version:    2.21.0
Sidekiq Version:5.2.7
Go Version: unknown
GitLab information
Version:    12.1.1-ee
Revision:   b49d6585894
Directory:  /opt/gitlab/embedded/service/gitlab-rails
DB Adapter: PostgreSQL
DB Version: 10.7
URL:        https://gitlabhostname.tld
HTTP Clone URL: https://gitlabhostname.tld/some-group/some-project.git
SSH Clone URL:  git@gitlabhostname.tld:some-group/some-project.git
Elasticsearch:  no
Geo:        no
Using LDAP: no
Using Omniauth: yes
Omniauth Providers: bitbucket
GitLab Shell
Version:    9.3.0
Repository storage paths:

• default: /var/opt/gitlab/git-data/repositories GitLab Shell path: /opt/gitlab/embedded/service/gitlab-shell Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check

Checking GitLab subtasks ...
Checking GitLab Shell ...
GitLab Shell: ... GitLab Shell version >= 9.3.0 ? ... OK (9.3.0)
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Gitaly ...
Gitaly: ... default ... OK
Checking Gitaly ... Finished
Checking Sidekiq ...
Sidekiq: ... Running? ... yes
Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Incoming Email ...
Incoming Email: ... Reply by email is disabled in config/gitlab.yml
Checking Incoming Email ... Finished
Checking LDAP ...
LDAP: ... LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab App ...
Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
6/1 ... yes
1/2 ... yes
1/3 ... yes
1/4 ... yes
4/5 ... yes
5/6 ... yes
1/7 ... yes
6/8 ... yes
1/9 ... yes
1/10 ... yes
1/11 ... yes
1/12 ... yes
6/14 ... yes
1/15 ... yes
1/16 ... yes
1/17 ... yes
1/18 ... yes
1/19 ... yes
1/20 ... yes
1/22 ... yes
1/23 ... yes
1/24 ... yes
1/25 ... yes
1/26 ... yes
1/27 ... yes
1/28 ... yes
1/29 ... yes
1/31 ... yes
20/32 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.5.3 ? ... yes (2.6.3)
Git version >= 2.21.0 ? ... yes (2.21.0)
Git user has default SSH configuration? ... yes
Active users: ... 5
Elasticsearch version 5.6 - 6.x? ... skipped (elasticsearch is disabled)
Checking GitLab App ... Finished
Checking GitLab subtasks ... Finished

Workarounds

Remove the individual users that were added. Since they are already part of the group, they should still show as approvers.