Skip to content

Trigger suggested reviewers for merge requests created from a branch

What does this MR do and why?

Trigger suggested reviewers for merge requests created from a branch

  • Move to return unless project.can_suggested_reviewers? if this gets merged !99476 (merged)

Related to #376054 (closed)

How to set up and validate locally

  1. Ensure a SaaS (Gitlab.com) environment
    • One way of doing this is to add a env.runit file to the root GDK folder with the following snippet export GITLAB_SIMULATE_SAAS=1
  2. Set ultimate license on a group http://gdk.test:3000/admin/groups
  3. Create a project in the ultimate group
  4. Set the feature flag on rails console bin/rails c
project = Project.find(id-of-your-project) in the rail console
Feature.enable(:suggested_reviewers_control, project)
  1. Edit a file (like Readme.md) and create a merge request on the project
  2. You should see some failed workers in the sidekiq logs (due to lack of authentication) and some failed jobs in admin panel http://gdk.test:3000/admin/background_jobs
grep -r FetchSuggestedReviewersWorker log/sidekiq*

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alper Akgun

Merge request reports

Loading