Fixes top padding for skeleton notes
What does this MR do and why?
Fixes the top padding for skeleton notes.
Screenshots or screen recordings
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %15.5
added Beautifying our UI UI polish UX bugux frontend groupfoundations sectiondev severity4 typebug workflowpost-deploy-db-production + 1 deleted label
assigned to @mvanremmerden
Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.
This message was generated automatically. You're welcome to improve it.
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @rspeicher
,@kushalpandya
,@jivanvl
,@godfat
,@iamphill
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
mentioned in merge request !98973 (merged)
removed workflowpost-deploy-db-production label
- Resolved by Marcel van Remmerden
@seggenberger As you are the original author of !98973 (merged), would you mind having a look at this MR?
requested review from @seggenberger
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.This merge request changed undocumented Vue components in
vue_shared/
. Please consider creating Stories for these components:app/assets/javascripts/vue_shared/components/notes/skeleton_note.vue
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Artur Fedorov ( @arfedoro
) (UTC+2)Denys Mishunov ( @dmishunov
) (UTC+2)UX Matej Latin ( @matejlatin
) (UTC+2)Maintainer review is optional for UX To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits a93370ae and f6678882
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.56 MB 3.56 MB - 0.0 % mainChunk 1.92 MB 1.92 MB - 0.0 %
Please look at the full report for more details
Read more about how this report works.
Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for f6678882expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Create | 28 | 0 | 1 | 5 | 29 | ❗ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 52 | 0 | 8 | 11 | 60 | ❗ | | Plan | 47 | 0 | 1 | 1 | 48 | ❗ | | Verify | 12 | 0 | 1 | 4 | 13 | ❗ | | Protect | 2 | 0 | 0 | 1 | 2 | ❗ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 152 | 0 | 14 | 24 | 166 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Marcel van Remmerden
@arfedoro Would you mind reviewing this tiny fix?
requested review from @arfedoro
@seggenberger
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added 40 commits
-
e8b66d15...231b86bf - 39 commits from branch
master
- b488039e - Fixes top padding for skeleton notes
-
e8b66d15...231b86bf - 39 commits from branch
removed review request for @seggenberger
- Resolved by Frédéric Caplette
added 2 commits
requested review from @f_caplette and removed review request for @arfedoro
added 115 commits
-
96fa69ab...4d41cfe1 - 113 commits from branch
master
- 73f234a1 - Fixes top padding for skeleton notes
- 566a40e5 - Use mixin for top margin
-
96fa69ab...4d41cfe1 - 113 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @stanhu
,@smcgivern
,@marin
,@ClemMakesApps
,@mikegreiling
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
Edited by GitLab Reviewer-Recommender Bot- Resolved by Frédéric Caplette
removed review request for @f_caplette
requested review from @f_caplette
enabled an automatic merge when the pipeline for 9548425c succeeds
mentioned in commit 715ca785
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!1521 (merged)
added devopsmanage label and removed 1 deleted label
added releasedpublished label and removed releasedcandidate label