Skip to content
Snippets Groups Projects

Fixes top padding for skeleton notes

Merged Marcel van Remmerden requested to merge fix-skeleton-padding into master
All threads resolved!

What does this MR do and why?

Fixes the top padding for skeleton notes.

Screenshots or screen recordings

Before After
image Screenshot_2022-09-30_at_10.21.46

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Marcel van Remmerden

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 2 commits

    • e8b66d15 - Fixes top padding for skeleton notes
    • 96fa69ab - Use mixin for top margin

    Compare with previous version

  • Artur Fedorov approved this merge request

    approved this merge request

  • Artur Fedorov requested review from @f_caplette and removed review request for @arfedoro

    requested review from @f_caplette and removed review request for @arfedoro

  • Marcel van Remmerden resolved all threads

    resolved all threads

  • Marcel van Remmerden resolved all threads

    resolved all threads

  • added 115 commits

    Compare with previous version

  • Suggested Reviewers (beta)

    The individuals below may be good candidates to participate in the review based on various factors.

    You can use slash commands in comments to quickly assign /assign_reviewer @user1.

    Suggested Reviewers
    @stanhu, @smcgivern, @marin, @ClemMakesApps, @mikegreiling

    If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/357923.

    Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".

    Edited by GitLab Reviewer-Recommender Bot
  • Frédéric Caplette removed review request for @f_caplette

    removed review request for @f_caplette

  • added 1 commit

    Compare with previous version

  • requested review from @f_caplette

  • Frédéric Caplette resolved all threads

    resolved all threads

  • Frédéric Caplette approved this merge request

    approved this merge request

  • Frédéric Caplette enabled an automatic merge when the pipeline for 9548425c succeeds

    enabled an automatic merge when the pipeline for 9548425c succeeds

  • mentioned in commit 715ca785

  • added workflowstaging label and removed workflowcanary label

  • 🤖 GitLab Bot 🤖 added devopsmanage label and removed 1 deleted label

    added devopsmanage label and removed 1 deleted label

  • Please register or sign in to reply
    Loading