Skip to content

GitLab Next

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
GitLab
GitLab
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
    • Locked Files
  • Issues 36,918
    • Issues 36,918
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
    • Iterations
  • Merge requests 1,548
    • Merge requests 1,548
  • Requirements
    • Requirements
    • List
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
    • Test Cases
  • Operations
    • Operations
    • Metrics
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI/CD
    • Code Review
    • Insights
    • Issue
    • Repository
    • Value Stream
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GitLab.org
  • GitLabGitLab
  • Merge requests
  • !993

Merged
Created Dec 22, 2016 by Timothy Andrew@timothyandrewContributor20 of 20 tasks completed20/20 tasks

Fix 500 error while navigating to the `pages_domains` 'show' page.

  • Overview 4
  • Commits 2
  • Pipelines 4
  • Changes 4

Summary

  1. The path of the "pages_domains" show page is of the form 'group/project/pages/domains/<domain_name>'
  2. Rails looks at params[:id] (which should be the domain name), and finds the relevant model record.
  3. Given a domain like foo.bar, Rails sets params[:id] to foo (should be foo.bar), and sets params[:format] to bar
  4. This commit fixes the issue by adding a route constraint, so that params[:id] is set to the entire foo.bar domain name.

Tasks

  • [#1447 (closed)/!993 (merged)] Error 500 when showing details for a Pages custom domain
    • Investigate
      • Get GitLab CI working locally
      • Reproduce the issue
      • Check if related to !1448 (closed)
      • Why did this happen now?
    • Implementation
    • Tests
      • Added
      • Passing
    • Meta
      • CHANGELOG entry created
      • Documentation created/updated
      • API support added
      • Branch has no merge conflicts with master
      • Squashed related commits together
      • Check for clean merge with EE
      • Added screenshots
    • Review
      • Endboss
    • Wait for merge

  • Closes #1447 (closed)
  • Closes #1448 (closed)
Assignee
Assign to
Reviewer
Request review from
8.15
Milestone
8.15 (Past due)
Assign milestone
Time tracking
Source branch: 1447-custom-domain-500