Skip to content

Group SAML prevents blank NameID on Identity

James Edwards-Jones requested to merge jej/improve-group-saml-name-id into master

What

Prevents Identity#extern_uid from being blank for GroupSAML identities.

Why

When SAML for GitLab.com is misconfigured the NameID can be missing and end up as a blank extern_uid. Since we use this to identify which user has signed in this can be problematic, hard for group admins to debug, and hard to for users to fix.

Related

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/10119 Relates to https://gitlab.com/gitlab-org/gitlab-ee/issues/10118

Does this MR meet the acceptance criteria?

Edited by James Edwards-Jones

Merge request reports