Skip to content

Move SyntaxHighlightFilter to end of pipelines

Brett Walker requested to merge bw-syntaxhighlighter into master

What does this MR do and why?

The SyntaxHighlightFilter can generate a lot of html for syntax coloring of code blocks, which can cause later filters to process more data. Moving to the end should reduce that some.

How to setup and validate locally

From a description or comment, you can try these different types code blocks

Ruby code:

  def markdown_field(object, field, context = {})
    object = object.for_display if object.respond_to?(:for_display)
    return '' unless object.present?

    redacted_field_html = object.try(:"redacted_#{field}_html")
    return redacted_field_html if redacted_field_html

    render_markdown_field(object, field, context)
  end

Plaintext code

def markdown_field(object, field, context = {})

Math code:

a^2 + b^2

Mermaid code:

erDiagram
    work_item_types ||--|{ widget_definitions : ""
    work_item_types {
      int id
      string name
      int namespace_id
    }

You can also try these in a project wiki, and verify that the Content Editor still works

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Brett Walker

Merge request reports