Skip to content

First iteration scan result policy refactor

- requested to merge licsense-policies-poc-refactor into master

What does this MR do and why?

This is a POC of refactoring the license scanning and security scanning scan result policy logic.

It demonstrates that we can separate out the parsing layer. (No change to the user at this time, all code refactor POC)

Before After
Screen_Shot_2022-09-27_at_5.16.54_PM Screen_Shot_2022-09-27_at_5.17.31_PM

Follow-up tasks

  • Break up the efforts in this refactor into their own issues and add to License scanning result policy epic
  • Remove duplicate code from each of the scan result policy directories and move to the common directory
  • Implement license scanning result policy specific fromYaml functions
  • Refactor policy-rule-builder into two. One for license scanning, one for security scanning

Describe in detail what your merge request does and why.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by -

Merge request reports