Skip to content

Part 1 - Hide top nav with vscode_web_ide feature flag

Paul Slaughter requested to merge 370139-hide-top-nav-with-new-web-ide into master

What does this MR do and why?

In this MR, we support the UX goals #370139 (closed) and https://gitlab.com/gitlab-org/gitlab-web-ide/-/issues/25#note_1076057874 and hide the top nav when :vscode_web_ide feature flag is enabled.

Screenshots or screen recordings

Default
Desc Before After (this MR)
🎉 With Feature.disable(:vscode_web_ide), no changes before_default_ff_off after_default_ff_off
🎉 With Feature.enable(:vscode_web_ide) top nav is now hidden before_default_ff_on after_default_ff_on
Noisy
Desc Before After (this MR)
🎉 With Feature.disable(:vscode_web_ide), no changes before_noisy_ff_off after_noisy_ff_off
🎉 With Feature.enable(:vscode_web_ide) top nav is now hidden before_noisy_ff_on after_noisy_ff_on

How to set up and validate locally

  1. Visit the Web IDE for any public non-empty project.
  2. Try out with both the feature flag :vscode_web_ide enabled and disabled.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #370139 (closed)

Edited by Paul Slaughter

Merge request reports

Loading