Skip to content

Add isDefault to BranchRule type objects in GraphQL endpoint

Joe Woodward requested to merge feat/graphql-branch-rules--default-branch into master

What does this MR do and why?

Adds isDefault to BranchRule type objects in the GraphQL endpoint. The value is a boolean and is true if the protected_branch.name == protected_branch.project.default_branch.

#362706 (closed) -> #372362 (closed)

How to set up and validate locally

  1. Find a project.full_path of a project that has at least one protected branch
       project = ProtectedBranch.last.project
       project.full_path
  2. Test permissions by assigning yourself as a guest to the project
      # user = User.find_by(email: "YOUR_EMAIL") # Use this if you do not use the default admin user in GDK
      user = User.find_by(email: "admin@example.com")
      project.add_guest(user)
  3. Visit http://gdk.test:3000/-/graphql-explorer
  4. Execute the following query, replace the full path value (as guest you should not see any rules)
     {
       project(fullPath: "FULL_PATH") {
         branchRules {
           nodes {
             name
             isDefault
           }
         }
       }
     }
  5. Make yourself a maintainer
      project.add_maintainer(user)
  6. Execute the following query, replace the full path value (as maintainer you should see all the rules)
     {
       project(fullPath: "FULL_PATH") {
         branchRules {
           nodes {
             name
             isDefault
           }
         }
       }
     }

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports