Skip to content

Remove Git cheat sheet PDF LFS file

Stan Hu requested to merge sh-remove-lfs-pdf into master

What does this MR do and why?

spec/fixtures/git-cheat-sheet.pdf was checked in as an LFS file in 2019, but it's not really essential since it's just a test fixture. Having this file causes some unintended headaches:

  1. We now have to pay for LFS bandwidth for GitLab mirrors.

  2. When a conflicting GitLab.com SSL cert is installed (e.g. due to JAMF), a git clone will fail because of HTTPS verification. We've seen a number of people blocked as a result.

While it's useful to dogfood LFS, the downsides seem to outweight the upsides.

You can verify no more LFS requests are made:

GIT_TRACE_PACKET=1 GIT_TRANSFER_TRACE=1 GIT_CURL_VERBOSE=1 GIT_TRACE=1 git clone -b sh-remove-lfs-pdf git@gitlab.com:gitlab-org/gitlab.git

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Stan Hu

Merge request reports