Resolve "Migrate away from select2 in app/assets/javascripts/issuable/issuable_form.js"
What does this MR do and why?
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #374014 (closed)
Merge request reports
Activity
added frontend grouppersonal productivity maintenancerefactor sectiondev typemaintenance workflowready for development + 1 deleted label
assigned to @samdbeckham
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @filipa
,@iamphill
,@ClemMakesApps
,@jivanvl
,@mikegreiling
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
2 Warnings This merge request changed files with disabled eslint rules. Please consider fixing them. You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Disabled eslint rules
The following files have disabled
eslint
rules. Please consider fixing them:app/assets/javascripts/issuable/issuable_form.js
Run the following command for more details
node_modules/.bin/eslint --report-unused-disable-directives --no-inline-config \ 'app/assets/javascripts/issuable/issuable_form.js'
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Coung Ngo ( @cngo
) (UTC+1, same timezone as@samdbeckham
)Vitaly Slobodin ( @vitallium
) (UTC+2, 1 hour ahead of@samdbeckham
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerBundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 45d635fb and eadb8e73
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 3.55 MB 3.55 MB - -0.0 % mainChunk 1.92 MB 1.92 MB - 0.0 %
Note: We do not have exact data for 45d635fb. So we have used data from: 22da3230.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-review
job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangeradded typeignore label and removed typemaintenance label
removed maintenancerefactor label
added maintenancerefactor typemaintenance labels and removed typeignore label
changed milestone to %15.6
changed milestone to %15.5
- Resolved by Sam Beckham
@pgascouvaillancourt care to do the initial review here?
requested review from @pgascouvaillancourt
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for eadb8e73expand test summary
+-----------------------------------------------------------------------------------------+ | suites summary | +------------------------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Manage | 52 | 0 | 8 | 10 | 60 | ❗ | | Create | 30 | 0 | 1 | 5 | 31 | ❗ | | Verify | 12 | 0 | 1 | 4 | 13 | ❗ | | Protect | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 47 | 0 | 1 | 0 | 48 | ✅ | | Configure | 0 | 0 | 1 | 0 | 1 | ➖ | | Version sanity check | 0 | 0 | 1 | 0 | 1 | ➖ | | Feature flag handler sanity checks | 9 | 0 | 0 | 0 | 9 | ✅ | | Secure | 2 | 0 | 0 | 2 | 2 | ❗ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------------------------+--------+--------+---------+-------+-------+--------+ | Total | 154 | 0 | 14 | 21 | 168 | ❗ | +------------------------------------+--------+--------+---------+-------+-------+--------+
@pgascouvaillancourt
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
requested review from @mikegreiling and removed review request for @pgascouvaillancourt
requested review from @pgascouvaillancourt and removed review request for @mikegreiling
requested review from @mikegreiling and removed review request for @pgascouvaillancourt
Looks like @mikegreiling is OOO. @markrian could you pick this up for maintainer review please?
requested review from @markrian and removed review request for @mikegreiling
enabled an automatic merge when the pipeline for 59594d57 succeeds
Jobs failed, all seemingly unrelated. Rebasing @markrian
added 977 commits
-
581b47e1...f7cbf1f8 - 974 commits from branch
master
- 90eb5c5b - Removes dead select2 code
- ddbb8356 - Removes AutoWidthDropdownSelect as it's unused
- eadb8e73 - Removes unused imports from issuable form
Toggle commit list-
581b47e1...f7cbf1f8 - 974 commits from branch
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1
.Suggested Reviewers @filipa
,@iamphill
,@ClemMakesApps
,@jivanvl
,@mikegreiling
If you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923
.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
enabled an automatic merge when the pipeline for 81cab2a6 succeeds
mentioned in commit 2ed870a1
added workflowstaging-canary label and removed workflowready for development label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-production label and removed workflowproduction label
added releasedcandidate label
added devopsfoundations label and removed 1 deleted label
added releasedpublished label and removed releasedcandidate label