Make the confirmation modal for the design management comments clearer
This MR is a part of the ✨ Beautifying our UI (15.5) ✨
What does this MR do and why?
This MR updates the confirmation modal that is shown when canceling comment changes on the designs. The MR changes implementation from using gl-modal to using confirm_via_gl_modal to look consistent with the other similar cases (such as canceling a comment in MR or issue).
Screenshots or screen recordings
Cancel new comment creation
| Before | After |
|---|---|
 |
 |
Cancel existing comment edit
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Upload the design to the issue.
- Open the design and create a comment.
- Validate 3 flows:
- When you cancel a new comment that doesn't contain any text, it should just cancel
- When you cancel a new comment that has text, it should show the confirmation modal with the corresponding text (
Are you sure you want to cancel creating this comment?) - When you cancel editing a comment, it should show the confirmation modal with the corresponding text (
Are you sure you want to cancel editing this comment?)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Review progress:
Related to #374580 (closed)
Edited by Simon Knox