Migrate card component in the profile SSH page
What does this MR do and why?
Screenshots or screen recordings
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Navigate to the
Edit profileoption under the username - Go to the SSH keys menu -
http://127.0.0.1:3000/-/profile/keys - Select a key in the GDK (if there's nothing, you can add one)
- View the key details by clicking the sample key link
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #367115 (closed)
Merge request reports
Activity
added component:card frontend groupfoundations pajamasintegrate sectiondev severity4 typemaintenance + 1 deleted label
assigned to @sunjungp
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
Suggested Reviewers (beta)
The individuals below may be good candidates to participate in the review based on various factors.
You can use slash commands in comments to quickly assign
/assign_reviewer @user1.Suggested Reviewers @rspeicher,@reprazent,@ClemMakesApps,@peterhegman,@wortschiIf you do not believe these suggestions are useful, please apply the label Bad Suggested Reviewer. You can also provide feedback for this feature on this issue:
https://gitlab.com/gitlab-org/gitlab/-/issues/357923.Automatically generated by Suggested Reviewers Bot - an experimental ML-based recommendation engine created by ~"group::applied ml".
- A deleted user
added backend label
1 Warning 
You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Ross Fuhrman ( @rossfuhrman) (UTC-5, 7 hours behind@sunjungp)Alexandru Croitor ( @acroitor) (UTC+3, 1 hour ahead of@sunjungp)frontend Paul Gascou-Vaillancourt ( @pgascouvaillancourt) (UTC-4, 6 hours behind@sunjungp)Andrew Fontaine ( @afontaine) (UTC-4, 6 hours behind@sunjungp)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User
Resolved by 🤖 GitLab Bot 🤖Proper labels assigned to this merge request. Please ignore me.
1 Warning Please add a subtype label to this merge request. If you have added a type label and do not feel the purpose of this merge request matches one of the subtypes labels, please resolve this discussion.
Edited by 🤖 GitLab Bot 🤖
added maintenancerefactor label
changed milestone to %15.5
removed backend label
added Pajamas Migration Day + 1 deleted label
I created this MR for the PJ migration day. Could you take a look at this one? Thanks!
requested review from @pgascouvaillancourt
- Resolved by Andrew Fontaine
LGTM @sunjungp! Thanks for picking this up!
@afontaine could you have a look please? It looks like this also requires a backend review. It should be okay to go straight to the maintainer. @georgekoltsov could you review this as well??
- Last reply by Sunjung Park
requested review from @afontaine and @georgekoltsov and removed review request for @pgascouvaillancourt
-
@pgascouvaillancourt, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
