Skip to content

Use let_it_be in branches_spec

Alina Mihaila requested to merge am-improve-feature-tests into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Related #375023 (closed)

Before

Finished in 3 minutes 24.8 seconds (files took 12.29 seconds to load)
23 examples, 2 failures

Failed examples:

rspec ./spec/features/projects/branches_spec.rb:90 # Branches logged in as developer Find branches shows filtered branches
rspec ./spec/features/projects/branches_spec.rb:101 # Branches logged in as developer Delete unprotected branch on Overview removes branch after confirmation

[TEST PROF INFO] Time spent in factories: 00:40.087 (19.49% of total time)
[TEST PROF INFO] Factories usage

 Total: 70
 Total top-level: 47
 Total time: 00:40.087 (out of 03:33.050)
 Total uniq factories: 5

   total   top-level     total time      time per call      top-level time               name

      23          23       37.9021s            1.6479s            37.9021s            project
      23           0        2.1267s            0.0925s             0.0000s          namespace
      21          21        2.0764s            0.0989s             2.0764s               user
       2           2        0.1016s            0.0508s             0.1016s        ci_pipeline
       1           1        0.0074s            0.0074s             0.0074s            license

After

Finished in 1 minute 54.72 seconds (files took 8.18 seconds to load)
23 examples, 0 failures

[TEST PROF INFO] Time spent in factories: 00:08.286 (7.16% of total time)
[TEST PROF INFO] Factories usage

 Total: 24
 Total top-level: 14
 Total time: 00:08.286 (out of 01:59.913)
 Total uniq factories: 5

   total   top-level     total time      time per call      top-level time               name

      10          10        7.9617s            0.7962s             7.9617s            project
      10           0        1.3596s            0.1360s             0.0000s          namespace
       2           2        0.0816s            0.0408s             0.0816s        ci_pipeline
       1           1        0.0063s            0.0063s             0.0063s            license
       1           1        0.2373s            0.2373s             0.2373s               user

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Alina Mihaila

Merge request reports