Improve slow tests in merge_request_presenter_spec.rb
What does this MR do and why?
Related #374670 (closed)
Before
Finished in 1 minute 39.35 seconds (files took 14.28 seconds to load)
31 examples, 0 failures
[TEST PROF INFO] Time spent in factories: 01:27.978 (88.03% of total time)
[TEST PROF INFO] Factories usage
Total: 102
Total top-level: 71
Total time: 01:27.978 (out of 01:47.476)
Total uniq factories: 7
total top-level total time time per call top-level time name
31 31 76.6274s 2.4719s 76.6274s project
31 0 3.0082s 0.0970s 0.0000s namespace
31 31 10.9734s 0.3540s 10.9734s merge_request
3 3 0.1816s 0.0605s 0.1816s user
3 3 0.1160s 0.0387s 0.1160s external_status_check
2 2 0.0656s 0.0328s 0.0656s protected_branch
1 1 0.0144s 0.0144s 0.0144s license
After
Finished in 21 seconds (files took 12.54 seconds to load)
31 examples, 0 failures
[TEST PROF INFO] Time spent in factories: 00:09.994 (46.4% of total time)
[TEST PROF INFO] Factories usage
Total: 42
Total top-level: 41
Total time: 00:09.994 (out of 00:27.251)
Total uniq factories: 7
total top-level total time time per call top-level time name
31 31 7.0417s 0.2272s 7.0417s merge_request
3 3 0.1663s 0.0554s 0.1663s user
3 3 0.1090s 0.0363s 0.1090s external_status_check
2 2 0.0372s 0.0186s 0.0372s protected_branch
1 1 0.0073s 0.0073s 0.0073s license
1 1 2.6325s 2.6325s 2.6325s project
1 0 0.2070s 0.2070s 0.0000s namespace
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Alina Mihaila