Skip to content
Snippets Groups Projects

Update project member styles in GFM

Merged Dan MH requested to merge danmh-project-member-md-styles into master
All threads resolved!

What does this MR do and why?

Update project member styles to:

  1. exceed the minimum contrast for WCAG AA
  2. current user highlight visible on internal notes

This follows on from conversation in Slack. Thank you @nadia_sotnikova for your contributions :bow: :handshake: .

Notes about current user

  • The current user is sometimes highlighted in the UI.
  • The current user is not highlighted everywhere. This MR only changes the styles and doesn't look to highlight the current user consistently.
  • The value of the highlighting the current user was questioned in a design review. Removing or evolving this concept is outside the scope of this MR.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

For the purpose of these screenshoots @root is the highlighted as the current user

Before After Description
2issue issuetitleanddescription Issue title and description
2MR mr MR title and description
2worki workitem Work item description
2comment commentandthread Issue comment and thread
Screenshot_2022-09-20_at_10.52.36 127.0.0.1_3000_flightjs_Flight_-_issues_32_work_item_id_484 Internal note and thread
Screenshot_2022-09-20_at_10.53.03 127.0.0.1_3000_flightjs_Flight_-issues_32_work_item_id_484__1 Selected comment
2editpreview commentpreview Editor preview
127.0.0.1_3000_dashboard_todos_action_id__author_id__project_id__state_done_type_ todos Todo
127.0.0.1_3000_rails_letter_opener___1_ 127.0.0.1_3000_rails_letter_opener_ Todo email
  • Issue/MR Comment
  • Issue/MR Thread
  • Issue/MR Internal note
  • Issue/MR Internal note thread
  • Work item description
  • Issue description
  • MR description
  • Todos
  • Email
  • Comment preview
  • Description preview

Are there other places this affects that I've missed?

How to set up and validate locally

Pre work

  1. Find your current username by clicking on your profile picture at the top right of the UI. On GDK the default user is @root.

Issue tests

  1. In any project create a new issue
  2. Test issue the title by including usernames. For example: This is my MR title @root @brain.hirthe
  3. Test the issue description by including usernames. For example:
Lorem Ipsum is simply dummy text of the printing and typesetting industry. Lorem Ipsum has been the industry's standard dummy text ever since the 1500s, when an unknown printer took a galley of type and scrambled it to make a type specimen book.

@root @h5bp/commit451/gnuwget-21 @brain.hirthe 

It is a long established fact that @root a reader will be distracted by the readable content of a page when looking at its layout. @h5bp/commit451/gnuwget-21 The point of using Lorem Ipsum is @brain.hirthe that it has a more-or-less normal distribution of letters, as opposed to using 'Content here, content here', making it look like readable English.

- @root @brain.hirthe 
- @h5bp/commit451 

> Here is a quote @root 

> Another @brain.hirthe quote

### Titles can @marquis_wisozk too

Text text
  1. Add a comment to the issue that includes usernames. For example This is my comment @root @brain.hirthe
  2. Add an internal note to the issue that includes username. For example This is my internal note @root @brain.hirthe
  3. Copy the link to the comment using the ellipsis (...) menu. Go to this link to see the selected comment.
  4. Write a comment to the issue but don't submit it. Use the Preview tab to see a preview of the comment.

Work item tests

  1. Add a task using the Tasks widget below the issue description.
  2. Add usernames to the task title. For example This is my task title @root @brain.hirthe.
  3. Add usernames to the task description. For example This is my task description @root @brain.hirthe.

MR tests

  1. Same tests as an issue, but start by creating an MR.

Todo tests

  1. http://127.0.0.1:3000/dashboard/todos testing the issue and MR styles should have created some todos to test.

Email tests

  1. http://127.0.0.1:3000/rails/letter_opener/ to see emails generated by GitLab.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Dan MH

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added frontend label

    added frontend label

  • 1 Warning
    :warning: You've made some app changes, but didn't add any tests.
    That's OK as long as you're refactoring existing code,
    but please consider adding any of the maintenancepipelines, maintenanceworkflow, documentation, QA labels.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    frontend Eduardo Sanz-Garcia (@eduardosanz) (UTC+2, 1 hour ahead of @danmh) Peter Hegman (@peterhegman) (UTC-7, 8 hours behind @danmh)
    UX Matej Latin (@matejlatin) (UTC+2, 1 hour ahead of @danmh) Maintainer review is optional for UX

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Dan MH changed the description

    changed the description

  • Dan MH added UX label

    added UX label

  • Please wait for Reviewer Roulette to suggest a designer for UX review, and then assign them as Reviewer. This helps evenly distribute reviews across UX.

    This message was generated automatically. You're welcome to improve it.

  • Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits 5704641f and 40ca6a7d

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 3.54 MB 3.54 MB - 0.0 %
    mainChunk 1.92 MB 1.92 MB - 0.0 %

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • Dan MH changed the description

    changed the description

  • Dan MH added 1 commit

    added 1 commit

    • c2563acb - Update project member styles in GFM

    Compare with previous version

  • Dan MH changed the description

    changed the description

  • Dan MH changed the description

    changed the description

  • Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :exclamation: test report for 40ca6a7d

    expand test summary
    +-----------------------------------------------------------------------------------------+
    |                                     suites summary                                      |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    |                                    | passed | failed | skipped | flaky | total | result |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Manage                             | 52     | 0      | 8       | 10    | 60    | ❗     |
    | Verify                             | 12     | 0      | 1       | 3     | 13    | ❗     |
    | Plan                               | 53     | 0      | 4       | 0     | 57    | ✅     |
    | Create                             | 30     | 0      | 1       | 2     | 31    | ❗     |
    | Feature flag handler sanity checks | 9      | 0      | 0       | 0     | 9     | ✅     |
    | Configure                          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Protect                            | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Secure                             | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Version sanity check               | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package                            | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
    | Total                              | 160    | 0      | 17      | 15    | 177   | ❗     |
    +------------------------------------+--------+--------+---------+-------+-------+--------+
  • Dan MH changed the description

    changed the description

  • Dan MH marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Dan MH requested review from @andyvolpe

    requested review from @andyvolpe

  • Dan MH requested review from @lmeckley

    requested review from @lmeckley

  • Andy Volpe requested review from @jeldergl

    requested review from @jeldergl

  • Andy Volpe removed review request for @andyvolpe

    removed review request for @andyvolpe

  • Jeremy Elder approved this merge request

    approved this merge request

  • :wave: @jeldergl, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline has been started.

    For more info, please refer to the following links:

  • mentioned in issue danmh/danmh#10 (closed)

  • mentioned in issue #374580 (closed)

  • Dan MH added 583 commits

    added 583 commits

    Compare with previous version

  • Laura Callahan approved this merge request

    approved this merge request

  • Laura Callahan requested review from @peterhegman and removed review request for @lmeckley

    requested review from @peterhegman and removed review request for @lmeckley

  • Peter Hegman approved this merge request

    approved this merge request

  • Peter Hegman resolved all threads

    resolved all threads

  • Peter Hegman enabled an automatic merge when the pipeline for 0590c526 succeeds

    enabled an automatic merge when the pipeline for 0590c526 succeeds

  • merged

  • Peter Hegman mentioned in commit 8cf83665

    mentioned in commit 8cf83665

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading