Skip to content

Disable access to Sawyer Resource dynamic methods

Rodrigo Tomonarirequested to merge
rodrigo/disable-sawyer-resource-access into master

What does this MR do and why?

This change completely disables access to Sawyer Resource dynamic methods after having converted all Octokit responses into hashes.

As the logs don't have any occurrence of Sawyer Resource resource usage (message: 'Sawyer attribute called'), it's safe to change the patch to disable the usage completely and not only overridden Ruby methods.

Related to: https://gitlab.com/gitlab-org/gitlab/-/issues/373574 and https://gitlab.com/gitlab-org/gitlab/-/issues/371469

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Rodrigo Tomonari

Merge request reports