Skip to content

Clean up Gitlab::Usage::Metrics::Aggregates::Aggregate class

Mikołaj Wawrzyniak requested to merge mwaw/refactor_aggregates_class into master

What does this MR do and why?

There were some mixed responsibilities in lib/gitlab/usage/metrics/aggregates/aggregate.rb file, that would prevent extracting aggregated metrics feature to metrics instrumentation classes framework. This MR cleans up mentioned file as ground work before transfer to instrumentation classes (see follow up at !98206 (merged))

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

How to set up and validate locally

Trigger Service Ping from rails console

[1] pry(main)> Gitlab::Usage::ServicePingReport.for(output: :all_metrics_values)

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Mikołaj Wawrzyniak

Merge request reports