An error occurred while fetching this tab.
Fix Approval UI showing up for free plan
- Mar 06, 2019
-
-
- Removes `requires_approve?`. This was only being used in `merge_request_presenter` to hide/show the API paths. - Adds `approval_feature_available?` The API path checks have been updated to use this call. - Replaces `approvalsRequired` in the mr_widget_store with `hasApprovalsAvailable`. The previous property actually only checked if the `approvalsPath` was truthy or not. It looked like it checked the `approvalsRequired` from the server, but since this was camel case, this value never existed.
-
Mark Chao authored
This means existing unapproved rules would have no effect on MR merging process.
-
Mark Chao authored
`requires_approve?` went through several iterations, earliest one implies license by checking `approvals_required.nonzero?`. This was however set to true so caused EE specific UI to appear by mistake.
-