Skip to content

Optimize factory usage in specs/features

Pedro Pombeiro requested to merge pedropombeiro/cleanup-tests/374086 into master

What does this MR do and why?

Describe in detail what your merge request does and why.

The total running time of ./spec/features/runners_spec.rb is 73.83 seconds and it executes 5762 queries. This MR improves the factory usage.

Closes Improve slow tests in ./spec/features/runners_s... (#374086 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run FPROF=1 bundle exec rspec ./spec/features/runners_spec.rb and compare before/after.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro

Merge request reports