Skip to content

Optimize factory usage in Ci::Runner specs

Pedro Pombeiro (OOO from July 16th till Aug 7th) requested to merge pedropombeiro/cleanup-tests/374080 into master

What does this MR do and why?

Describe in detail what your merge request does and why.

Improves factory usage in ./spec/models/ci/runner_spec.rb.

Closes Improve slow tests in ./spec/models/ci/runner_s... (#374080 - closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

image

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

Run FPROF=1 bundle exec rspec ./spec/models/ci/runner_spec.rb and compare before/after.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Pedro Pombeiro (OOO from July 16th till Aug 7th)

Merge request reports